Repository navigation
feat(observability): distinguish HTTP response selection from delivery failure - #13
Draft
afourniernv wants to merge 1 commit into
Draft
afourniernv wants to merge 1 commit into
afourniernv wants to merge 1 commit into
Conversation
…ivery Signed-off-by: Alex Fournier <afournier@nvidia.com>
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Track response delivery separately from policy and response selection. Keep one primary HTTP Activity record and emit an additional correlated record only for a failure after that record. Preserve the distinction between OpenShell-observed delivery and any downstream application result.
Stacked review 6/6. This draft targets the mcp-correlation draft in this fork; its diff contains only this layer, not the whole stack. The HTTP core is reviewed upstream in NVIDIA#5214; this dependent draft is on the author fork because upstream base branches are not available.
Related Issue
Closes NVIDIA#5398.
Tracking: NVIDIA#5210 (remains open).
Changes
Testing
mise run pre-commitpassed; 1,684 network tests passed.0764c1c4c: 13 selected workflows, 1,552 spans and 433 OCSF records; protected synthetic APIs and authenticated GitHub. The agent executed actual tools; no span parents were rewritten. This is cumulative evidence, not isolated-layer E2E qualification.mise run testrerun passed with four test threads. Initial unchanged VM cleanup and gateway fixture flakes passed isolated reruns and the final full run. Fullmise run ciis not claimed.Checklist
Tested upstream snapshot:
638974575(merged NVIDIA#4789). Newer main has advanced; this draft does not claim validation against today's main. It is for incremental code review, not merge readiness. No Relay dependency or reverse workload-reporting endpoint is introduced.