Skip to content

kubectl ate create actor-template creates every document in a manifest - #2157

Open
Eric Curtin (ericcurtin) wants to merge 5 commits into
agent-substrate:mainfrom
ericcurtin:actortemplate-single-doc
Open

kubectl ate create actor-template creates every document in a manifest#2157
Eric Curtin (ericcurtin) wants to merge 5 commits into
agent-substrate:mainfrom
ericcurtin:actortemplate-single-doc

Conversation

@ericcurtin

@ericcurtin Eric Curtin (ericcurtin) commented Oct 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #2156

Creates each document independently and reports failures at the end. One parser shared with egress-policy and ate-setup.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@ericcurtin

Eric Curtin (ericcurtin) commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Julian Gutierrez Oschmann (@juli4n) Max Smythe (@maxsmythe) PTAL when you get a chance. Thank you!

@juli4n

Julian Gutierrez Oschmann (juli4n) commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Thanks, I added my thoughts in #2156 (comment).

@ericcurtin Eric Curtin (ericcurtin) changed the title kubectl ate create actor-template rejects multi-document manifests kubectl ate create actor-template creates every document in a manifest Oct 5, 2026
@ericcurtin

Eric Curtin (ericcurtin) commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Julian Gutierrez Oschmann (@juli4n) Done in 3994beb. One shared parser (internal/manifest). create actor-template creates every document and reports failures at the end. egress-policy still requires exactly one. PTAL.

@maxsmythe Max Smythe (maxsmythe) added kind/bug Something isn't working / bugfixes area/cli labels Oct 6, 2026
@juli4n

Julian Gutierrez Oschmann (juli4n) commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Tests are failing.

@ericcurtin

Eric Curtin (ericcurtin) commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Julian Gutierrez Oschmann (@juli4n) Thanks. The e2e failure was ko's trailing --- read as a second document. Fixed in 754107a, with a test. PTAL.

auto-merge was automatically disabled October 7, 2026 22:01

Head branch was pushed to by a user without write access

@ericcurtin

Eric Curtin (ericcurtin) commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Julian Gutierrez Oschmann (@juli4n) Addressed, PTAL.

thockin
Tim Hockin (thockin) reviewed Oct 11, 2026
View reviewed changes

@thockin Tim Hockin (thockin) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly I just want us to be clear about what we support and make the test cases clearer. This is hard to fix if we mess it up.

Comment thread cmd/kubectl-ate/internal/cmd/actortemplate.go Resolved
Comment thread cmd/kubectl-ate/internal/cmd/egress_policy.go Resolved
Comment thread internal/manifest/manifest_test.go Resolved
Comment thread internal/manifest/manifest_test.go Resolved
Comment thread internal/manifest/manifest_test.go Resolved
Comment thread internal/manifest/manifest_test.go Resolved
Comment thread internal/manifest/manifest_test.go Resolved
Comment thread internal/manifest/manifest_test.go Resolved
Comment thread internal/manifest/manifest_test.go Resolved
@ericcurtin

Eric Curtin (ericcurtin) commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

Tim Hockin (@thockin) Julian Gutierrez Oschmann (@juli4n) Addressed, PTAL when you get a chance. Thank you!

@ericcurtin

Eric Curtin (ericcurtin) commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

Merged main and resolved the conflicts. PTAL.

1 similar comment
@ericcurtin

Eric Curtin (ericcurtin) commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Merged main and resolved the conflicts. PTAL.

@ericcurtin

Eric Curtin (ericcurtin) commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Merged main again and resolved the conflict. PTAL.

@ericcurtin

Eric Curtin (ericcurtin) commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

Julian Gutierrez Oschmann (@juli4n) Tim Hockin (@thockin) Merged main and resolved the conflicts. The new access policy command now uses the shared parser too. PTAL.

@ericcurtin

Eric Curtin (ericcurtin) commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

Merged main and resolved the conflicts. PTAL.

@ericcurtin
kubectl-ate: create every document in an actor-template manifest
7445fdb 
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@ericcurtin

Eric Curtin (ericcurtin) commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Zoe Zhao (@zoez7) Luiz Oliveira (@laoj2) Rebased onto main and resolved the addressed threads. PTAL when you get a chance. Thank you!

@ericcurtin
kubectl-ate: clarify manifest tests and help
d4200e4 
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@ericcurtin

Eric Curtin (ericcurtin) commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

Clarified the manifest test cases and the help text in 5f48225.

@zoez7

Zoe Zhao (zoez7) commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Hi Eric Curtin (@ericcurtin), we are preparing for 1.0 release, and currently in a code freeze on main branch, see guidance here https://groups.google.com/g/ate-dev/c/vFELtvQLJ5g/m/Cuy69gn5BQAJ. (Join the https://groups.google.com/g/ate-dev group to get access.)

@ericcurtin

Eric Curtin (ericcurtin) commented Oct 31, 2026

Copy link
Copy Markdown
Contributor Author

Thank you Zoe Zhao (@zoez7), understood. I will leave this until after the 1.0 freeze.

@ericcurtin

Eric Curtin (ericcurtin) commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Tim Hockin (@thockin) Julian Gutierrez Oschmann (@juli4n) PTAL when you get a chance. Thank you!

@BenTheElder

Benjamin Elder (BenTheElder) commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Hi Eric Curtin (@ericcurtin): You promised to stop CC-ing an ever increasing list of maintainers in:
#1927 (comment)

Benjamin Elder (@BenTheElder) Sorry for the extra pings, and thank you for triaging. I will stop CCing maintainers on substrate PRs.

And yet you have not, with most of the pings coming in machine-speed waves, continuing to automatically subscribe an increasing number of maintainers to each PR:

Details
Start (UTC) Span Comments PTAL pings PRs
2026-09-29 23:54:20 6s 3 3 #1925 #1927 #1929
2026-10-06 01:18:26 3s 3 3 #1925 #1989 #2050
2026-10-12 00:25:19 6s 5 5 #1925 #1927 #2093 #2226 #2473
2026-10-12 20:33:54 3s 3 3 #2456 #2157 #2093
2026-10-14 00:25:47 7s 5 5 #1989 #2093 #2183 #2369 #2604
2026-10-14 08:38:36 159s 4 4 #2430 #2157 #2604 #2456
2026-10-17 09:00:01 8s 6 6 #2532 #2369 #2226 #2157 #1927 #2485
2026-10-23 01:50:04 340s 14 13 #2604 #2681 #2706 #2748 #2772 #2811 #2846 #2956 #3132 #1925 #2183 #2226 #2430 #2473
2026-10-23 22:26:47 18s 5 5 #2748 #3132 #3163 #3180 #3154
2026-10-26 23:04:07 3s 3 3 #3195 #3202 #3207
2026-10-30 15:08:48 3s 3 3 #1925 #3132 #3180
2026-11-02 00:02:58 12s 9 9 #2157 #2183 #2226 #2430 #2473 #2604 #2811 #3163 #3202
2026-11-03 23:53:35 4s 4 4 #3195 #3603 #3432 #3542

This is unfair both to maintainers who are triaging an enormously active and growing project and to other contributors who are politely refraining from gaming the system like this.

The automated inbox stuffing:
Screenshot 2026-10-22 at 7 24 55 PM

Is unwelcome, and multiple other maintainers have complained to us.

Please stop, this is a shared space, and it will be totally unsustainable if more people mimic this behavior.

You were also made aware multiple times of the project's code freeze and continued to ping on PRs after being asked to wait on those until after the freeze, including this one.

@ericcurtin

Eric Curtin (ericcurtin) commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, you are right. I have stopped pinging on substrate PRs and will wait for the freeze to lift. Thank you.

@ericcurtin
Use Agent Substrate Authors copyright
b1857fc 
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@ericcurtin

Eric Curtin (ericcurtin) commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Benjamin Elder (@BenTheElder) DCO sign-off fixed, no code changes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juli4n Julian Gutierrez Oschmann (juli4n) juli4n left review comments
@thockin Tim Hockin (thockin) thockin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/cli kind/bug Something isn't working / bugfixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reject trailing YAML documents in actor-template create manifests

6 participants

@ericcurtin @juli4n @zoez7 @BenTheElder @thockin @maxsmythe