Repository navigation
Pull optimization: unpack largest layers first in pullWith - #3749
Open
Amy (amyxu-08) wants to merge 4 commits into
Open
Amy (amyxu-08) wants to merge 4 commits into
Amy (amyxu-08) wants to merge 4 commits into
Conversation
…ocessed first Change-Id: I9c8b934f6d220134ca30dc9ace478f3d80bb8784 Signed-off-by: Amy Xu <amywxu@google.com>
Change-Id: I60ae80f216eed307cf76ede3526608f1747ad11a Signed-off-by: Amy Xu <amywxu@google.com>
Amy (amyxu-08)
force-pushed
the
lpt-image-pull
branch
from
November 9, 2026 22:48
5004ab7 to
95ed0e4
Compare
Change-Id: I04d5162c09d874c8317babd1c86fb2bc2b0f734a Signed-off-by: Amy Xu <amywxu@google.com>
Amy (amyxu-08)
force-pushed
the
lpt-image-pull
branch
from
November 10, 2026 01:08
166b601 to
b8780ed
Compare
Amy (amyxu-08)
marked this pull request as ready for review
November 10, 2026 01:14
Change-Id: I7fcf3c044be39217f5b027efae52094b072b6986 Signed-off-by: Amy Xu <amywxu@google.com>
Amy (amyxu-08)
force-pushed
the
lpt-image-pull
branch
from
November 10, 2026 05:11
d189e91 to
cc25665
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the optimizations outlined in Investigating Substrate Image Pull Speed
Currently, images with skewed layer sizes and a total number of layers > layerPullConcurrency (=4) may have larger layers queue behind smaller ones when unpacking. This PR uses Longest Processing Time (LPT) scheduling based on the size of the image layers.
AI use: AI-assisted, I reviewed and tested it (
go test -race -count=3 -shuffle=on ./internal/imagecacheandhack/run-e2e.shagainst dev cluster).Change-Id: I9c8b934f6d220134ca30dc9ace478f3d80bb8784