Repository navigation
Pull optimization: use klauspost compress/gzip instead of stdlib compress/gzip - #3753
Draft
Amy (amyxu-08) wants to merge 2 commits into
Draft
Amy (amyxu-08) wants to merge 2 commits into
Amy (amyxu-08) wants to merge 2 commits into
Conversation
…paths in test Change-Id: I2946604b81fd9e09cd128455ad15e3eb08f7038e Signed-off-by: Amy Xu <amywxu@google.com>
Amy (amyxu-08)
force-pushed
the
gzip-klauspost
branch
from
November 10, 2026 03:10
89467bc to
2e6f242
Compare
Amy (amyxu-08)
changed the title
Amy (amyxu-08)
changed the title
Change-Id: I8b324c6d9e61c602ac48fbf492b03f47a4ae74bd Signed-off-by: Amy Xu <amywxu@google.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the optimizations outlined in Investigating Substrate Image Pull Speed
go-containerregistry decompresses gzip layers with the stdlib, so readVerifiedLayer now decompresses layer.Compressed() itself with klauspost/compress, mirroring the code in go-containerregistry's Uncompressed (both go-containerregistry and readVerifiedLayer use klauspost/compress for zstd). This change is similar to how sandbox_assets.go and containerd use klauspost/compress/gzip for gzip layer decompression (issue, PR).
AI use: AI-assisted, I reviewed and tested it (
go test -race -count=3 -shuffle=on ./internal/imagecacheandhack/run-e2e.shagainst dev cluster).