Repository navigation
chore(deps): Bump dnspython from 2.8.0 to 2.9.0 in /requirements - #310
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [dnspython](https://github.com/rthalley/dnspython) from 2.8.0 to 2.9.0. - [Release notes](https://github.com/rthalley/dnspython/releases) - [Changelog](https://github.com/rthalley/dnspython/blob/main/doc/whatsnew.rst) - [Commits](rthalley/dnspython@v2.8.0...v2.9.0) --- updated-dependencies: - dependency-name: dnspython dependency-version: 2.9.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
carloshvp
left a comment
There was a problem hiding this comment.
Reviewed head 4639b7f140dbc85e05d71b1505191da624c19387 against base 04996416a4963dd5369b5d4ad644aa21822d9dde.
Please preserve the committed cryptography override when updating dnspython. requirements/agt.txt changes cryptography==50.0.1 to 48.0.1 and removes the override provenance, while requirements/agt-overrides.txt still requires cryptography>=50.0. The existing tests/unit/test_dependency_security_floors.py::test_agt_lock_carries_no_cryptography_below_the_floor parses this lock and requires a version of at least 50.0; (48, 0, 1) >= (50, 0) is false. The isolated governance install also consumes this lock with --no-deps, so the downgraded pin is actually installed if that job is reached.
Regenerate using the command already recorded in requirements/agt.in, including --override requirements/agt-overrides.txt --universal --python-version 3.11 --generate-hashes. A bounded correction can restore the base's complete cryptography 50.0.1 hash block and override annotation while retaining dnspython 2.9.0. Then run the dependency-floor test and the required CI matrix.
Validation: compared exact provider blobs and the unchanged override/test; no repository code was executed locally because source preparation failed. Hosted Python 3.11/Linux job 128954098863 reaches the Test step and fails; I could not retrieve its log, so I am not attributing its entire failure output to this assertion. The remaining matrix jobs were cancelled and governance was skipped. This review does not claim passing local tests or full CI.
Bumps dnspython from 2.8.0 to 2.9.0.
Release notes
Sourced from dnspython's releases.
Changelog
Sourced from dnspython's changelog.
... (truncated)
Commits
e790c8fadd missing test fileb72af67CI release branch updatebdd62ferelease prepbafc963Merge branch 'decompression-limit'c5fecf5release tidyingc7686f3update dependencies3c855c8more type lint52815c9type lintf563427lintb485e46Limit decompression to a chain length of at most 16 pointers.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.