Repository navigation
test(e2e): scroll a sandbox row into view before checking it - #127
Merged
Merged
Conversation
Since server-side pagination (#122) the sandbox list has a third filter and a pager above it, and at CI's 1280x720 viewport its second row starts below the fold of the page's scrolling content area. Cypress counts a row its scroll container clips as not visible, so "displays sandbox list with different phases" failed on main's push runs for 61e2590 and 70afb39 ("its content is being clipped by one of its parent elements, which has a CSS property of overflow"). Each row is now scrolled to before it is checked. The workspace draft-summary stub also matched only a bare path, while the paged list asks with ?sandbox=..., so those requests fell through to a BFF that is not running and answered 500. The stub now matches with a query. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e2efails onmain's push runs for61e2590(#122) and70afb39(#123). Each time one test fails:sandbox-lifecycle.cy.ts, "displays sandbox list with different phases". The same tree passed in #123's own run and passes locally, so it is intermittent.Why it fails. Cypress says why:
Since server-side pagination (#122), the sandbox list has a third filter field and a pager above it. At CI's 1280×720 viewport, the second row (
data-processor) starts below the fold of the page's scrolling content area; the failure screenshots show onlymy-agentin view. Cypress counts a row clipped by its scroll container as not visible. Whether the row is clipped depends on how the page lays out on the runner.What changes (tests only):
?sandbox=…, so those requests fell through to a BFF that is not running in e2e and answered 500 in every run (visible in the failure screenshots). The stub now matches with a query.Checked. All 47 Cypress specs pass locally. The failure did not reproduce locally, so this PR's own
e2erun is the real check.🤖 Generated with Claude Code