Repository navigation
Conversation
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Contributor
Author
|
Superseded: the Dependabot ignore and the grpcio-tools lock revert are now on #19 directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore
grpcio-toolsin Dependabot. It stamps its owngrpcioandprotobufversions into the committed stubs insrc/openshell/_proto. Moving 1.78.0 to 1.85.1 (#19) would make the stubs requireprotobuf7.x andgrpcio>=1.85.1at import, which breaks protobuf 6.x users and the declaredgrpcio>=1.60floor.Raising the floors is tracked in #24 for 0.2.0, where this ignore is lifted.
After this merges, close #19 and comment
@dependabot recreateso the remaining updates come back withoutgrpcio-tools.