Repository navigation
perf(website): server components, MotionConfig reducedMotion, static counters - #704
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Addressed review feedback:
🤖 Generated with Claude Code |
|
Claude finished @ajitpratap0's task in 25s —— View job Review of PR #704: server components, MotionConfig,
|
|
Claude finished @ajitpratap0's task in 23s —— View job Review of PR #704: server components, MotionConfig, static countersI read the full diff ( The change is clean overall. Moving to Issues and suggestions
Security and tests
Overall this looks good to merge after the description fixes and the optional |
…edMotion, static counters Drop 'use client' from CompareContent and VscodeContent, split the benchmarks disclosure into a client RawDataToggle using CSS grid-template-rows, remove AnimatePresence mode=wait from CodeExamples, add a Providers component with MotionConfig reducedMotion=user and LazyMotion, move shared components to m, and render AnimatedCounter with its final value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RkzVu3JY9Y6BRWfjesWts9
… components Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RkzVu3JY9Y6BRWfjesWts9
219fb2a to
9f0d35b
Compare
|
Claude finished @ajitpratap0's task in 17s —— View job Review of PR #704I read the code on the branch. I did not run typecheck, lint, build or a browser test. Overall: The change looks good. Should fix
Optional
PerformanceMoving Security and testsNo security concerns. There are no automated tests for these UI changes. The two unchecked test-plan items still need doing: the reduced-motion check in a browser and the Fix 1 and the description update, and this is good to merge. |
Summary
'use client'from CompareContent and VscodeContent; BenchmarksContent is now a server component with only a small clientRawDataToggle(CSSgrid-template-rows: 0fr to 1fr, no motion).AnimatePresence mode="wait"(no exit overlap).Providers(MotionConfig reducedMotion="user"+LazyMotionwith asyncdomAnimation) wired in the root layout; Navbar, SearchModal, ThemeToggle, Button, GlassCard, ScrollProgressBar, GitHubStarButton, CopyButton, Playground usem.motionbecause it useslayoutId.First-load JS (gzip, sum of chunks referenced by prerendered HTML, before -> after): /compare 347,406 -> 324,218 (-23.2 KB); /vscode 347,311 -> 324,218; /benchmarks 348,725 -> 325,377; / 351,842 -> 358,341 (+6.5 KB, home needs full motion for layoutId plus lazy features).
Test Plan
npm run typecheckclean;npm run lint0 errors (7 pre-existing warnings);npm run buildpassesBreaking Changes
None.
Closes #647
Part of #634
🤖 Generated with Claude Code
https://claude.ai/code/session_01RkzVu3JY9Y6BRWfjesWts9