Repository navigation
feat(website/home): home sections redesign (proof strip, integrations, dialect cards, performance) - #716
feat(website/home): home sections redesign (proof strip, integrations, dialect cards, performance)#716ajitpratap0 wants to merge 2 commits into
Conversation
…e it everywhere - Rename "Trusted by Developers" to "Built for production" (ProofStrip): exactly four cards (stars or race-clean fallback, tests, parse-stage latency, dialects) in a 2x2 / 4x1 grid, plus an integration strip of text and neutral glyphs linking to the MCP guide, /vscode/ and editor docs. - Dialect cards: one neutral glyph, one accent colour, dialect string and only sourced metrics (QA corpus pass N/N for Snowflake/ClickHouse); unsourced percentages and status badges removed. Cards link to /docs/sql-compatibility/#supported-dialects. - Performance: all figures parse stage from metrics.ts, single neutral value colour, solid brand bars, and a Reproduce snippet with copy. - Merge McpSection and VscodeSection into UseEverywhere. - Rename the feature grid heading to avoid a duplicate h2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RkzVu3JY9Y6BRWfjesWts9
|
Deployment failed for project gosqlx-website with the following error: Learn More: https://vercel.com/coolajitpratapsingh0-9932s-projects?upgradeToPro=build-rate-limit |
|
Claude finished @ajitpratap0's task in 28s —— View job Review of PR #716: home sections redesignOverall this is a clean, well-scoped change. I found no blocking issues. I read the diff but did not run the build, typecheck or lint, so I'm relying on the PR's test plan for those. What looks good
Suggestions (non-blocking)
Security and performance
Still open from the PR's test plan: Lighthouse CI and the phone-width check on the Vercel preview. |
…ports Use compact display values (3.14M, 858K), stay at 2 columns until lg and scale the font down on small screens. Verified no overflow from 320px to 1280px. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RkzVu3JY9Y6BRWfjesWts9
|
Fixed the stat card clipping (pushed to feat/home-sections). Values now use formatOps (~3.14M, ~858K) with ns latencies as-is, the grid stays 2 columns until lg (4 at lg+), and the font scales text-2xl / sm:text-3xl / xl:text-4xl with whitespace-nowrap. Measured in headless Chrome against next start at 320, 375, 640, 768, 900, 1023, 1024 and 1280px: scrollWidth equals clientWidth for all four figures at every width, so nothing clips. typecheck, lint and build pass. 🤖 Generated with Claude Code |
|
Deployment failed for project gosqlx-website with the following error: Learn More: https://vercel.com/coolajitpratapsingh0-9932s-projects?upgradeToPro=build-rate-limit |
|
Claude finished @ajitpratap0's task in 19s —— View job Review of PR #716 (re-review after the stat-card clipping fix)I read the diff and the Good
Suggestions (non-blocking)
Security and performance: there are no concerns. The diff has no Still open from your test plan: Lighthouse CI and the phone-width check on the Vercel preview. The Vercel deploy hit the free-tier rate limit, so the preview may not be available yet. |
Summary
Home sections redesign (plan item 2.5).
TrustSection->ProofStrip): renamed to "Built for production". Exactly four cards in agrid-cols-2 lg:grid-cols-4grid (2x2, then 4x1), so no orphan at any breakpoint: GitHub stars (live; replaced by a "race-detector clean" card when the API is unavailable, so the count stays at 4), Go test functions,~0.32 µsto parse a simple SELECT (parse stage, Apple M4, Go 1.27), and 8 dialects. Every figure comes fromsrc/data/metrics.tsor the live stars API./docs/mcp-guide/, VS Code links to/vscode/, and Neovim and JetBrains link to/docs/editors/.... Tap targets are at least 44px.QA corpus pass N/N (v1.14.0), shown where a corpus run exists (Snowflake 87/87, ClickHouse 69/83). The other dialects show "Coverage notes". The unsourced 95/85/80% figures and status badges are gone (Q12). Every card links to/docs/sql-compatibility/#supported-dialects.bg-brandinstead of a gradient. The chart's aria-label now lists the values. A new Reproduce snippet has an always-visible copy button and a status live region. The command is stored asBENCH_ENV.commandin metrics.ts.McpSectionandVscodeSectionare merged into one two-column section (AI assistants, Editors).CHANGELOG is not edited (the release is being prepared elsewhere). Suggested entry: "Website home: Built for production proof strip, sourced dialect metrics, reproducible benchmark command, merged MCP/editor section."
Test Plan
cd website && npm ci && npm run typecheckpassesnpm run lintreports 0 errors (7 warnings, all already present in files this PR does not change, plus the existing AnimatedBars effect)npm run check:metricspassesnpm run buildpassesgo test -run='^$' -bench=BenchmarkPerformanceBaseline -benchmem -count=1 ./pkg/sql/parser/runs on an Apple M4 (SimpleSelect 331 ns/op, ComplexQuery 1191 ns/op, consistent with metrics.ts)next start: proof strip, performance, Reproduce snippet and Use it everywhere render, with no horizontal overflow at desktop widthBreaking Changes
None. These are website-only component changes.
TrustSection,McpSectionandVscodeSectionare removed; they were used only by the home page.Closes #663
Part of #634
🤖 Generated with Claude Code
https://claude.ai/code/session_01RkzVu3JY9Y6BRWfjesWts9