Repository navigation
feat(website/home): hero redesign with solid headline, formatted-SQL demo and proof line - #717
ajitpratap0 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Deployment failed for project gosqlx-website with the following error: Learn More: https://vercel.com/coolajitpratapsingh0-9932s-projects?upgradeToPro=build-rate-limit |
|
Fixed in 124de60: removed 🤖 Generated with Claude Code |
|
Claude finished @ajitpratap0's task in 20s —— View job PR #717 review: hero redesignOverall this is a clean, well-scoped change. I read the diff only and did not build or run it. Below are a few issues worth considering, most important first. 1. Stale output after a tab or dialect switch (medium)
2. Formatted view when 3.
4. Parse timing (low) 5.
6. Accessibility
7. Go generator 8. Styling
Security: no concerns. There is no Tests: there are no automated tests for No blocking issues. Item 2 is the one I would fix before merging. |
|
Claude finished @ajitpratap0's task in 28s —— View job PR review: hero redesign (#717)I reviewed the diff only. I didn't build or run anything. Overall this is a clean, well-scoped change, and I found no blocking issues. What looks good
Suggestions (non-blocking)
Security and performance
|
…demo and proof line - Solid h1 with the brand gradient (brand -> accent tokens, light/dark aware) only on "speed of Go"; drop hyphens-auto, add text-balance. - Hero fills 100svh minus the 4rem navbar and is top-aligned so the live demo starts above the fold at 1440x900 and phone widths. - Demo defaults to formatted SQL with chips (measured parse time, dialect, statement type); the AST tab becomes "Tree" and drops null/false/empty fields. gen-sample-ast now also emits the formatted sample so no raw JSON is shown before WASM loads. - Proof line under the CTAs built only from src/data/metrics.ts. Closes #662 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RkzVu3JY9Y6BRWfjesWts9
The parsed-in timing chip changes on every debounced keystroke, causing screen readers to announce it repeatedly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RkzVu3JY9Y6BRWfjesWts9
124de60 to
7d169b1
Compare
|
Claude finished @ajitpratap0's task in 15s —— View job Review of PR #717: hero redesignI read the diff against Should fix
Nice to have
What looks good
|
Summary
Implements the Phase 2 hero redesign (#662):
text-fgh1; the brand gradient (from-brand to-accent, both semantic tokens so light mode switches to the darker AA values) applies only to "speed of Go". Removedhyphens-auto/break-words, addedtext-balance. Mascot logo unchanged.min-h-[calc(100svh-4rem)](4rem = fixed navbar) and top-aligned instead of vertically centred, with tighter spacing. At 1440x900 the whole demo, input and output, fits in the first viewport; on a ~400px-wide phone viewport the demo starts at ~595px. The mobile input is capped at 180px so the output tabs come into view sooner.parsecall is timed, and only after WASM loads), the dialect and the statement type. The "AST" tab is now Tree and drops null/false/empty-string/empty-array/empty-object fields.website/scripts/gen-sample-astnow also writes the formatted sample (formatter.FormatString, the same callwasm/main.gouses), so the precomputed pre-WASM view is real formatted SQL and not raw JSON. The deferred WASM load from perf(website/home): defer WASM load until user intent; SW only on /playground #701 is unchanged.src/data/metrics.ts: headline parse-stage ops/sec with its caption (stage, hardware, Go version), which links to /benchmarks, plus dialect count, lint-rule count and test count. No competitor numbers.CHANGELOG.md was not edited, per maintainer instruction. Release note for the next version: "Homepage hero redesign: brand-highlighted headline, formatted-SQL demo with parse/dialect/statement chips, pruned Tree view, metrics-sourced proof line."
Test Plan
cd website && npm ci && npm run typecheck && npm run lint && npm run build: typecheck clean; lint has 0 errors and 7 warnings, allreact-hooks/set-state-in-effectand none new (the 2 in MiniPlayground are on the existing parse effects); build succeedsnpm run check:metrics: passestask check(fmt, vet, lint, race tests): passes;gen-sample-astregenerated, and the AST is the same apart from the newformattedfieldnullorfalse.github/workflows/lighthouse.yml) on this PRBreaking Changes
None.
Closes #662
Part of #634
🤖 Generated with Claude Code
https://claude.ai/code/session_01RkzVu3JY9Y6BRWfjesWts9