[ajitpratap0]

Summary

Makes the version that GoSQLX reports match the release.

• LSP: initialize now returns gosqlx.Version as serverInfo.version. It used to return a hard-coded "1.0.0" (pkg/lsp/handler.go). pkg/lsp already imported pkg/gosqlx, so the import direction does not change.
• CLI: gosqlx --version now reads the cmd.Version variable through rootCmd.Version = Version in init(). Release builds can set it with -X github.com/ajitpratap0/GoSQLX/cmd/gosqlx/cmd.Version=<tag>. A plain go build still prints the hard-coded default.
• vscode-publish.yml: the bundled gosqlx binary gets the tag version (${RELEASE_TAG#v}, checked against semver, passed in through env). The linux-x64 smoke test now fails if --version does not print gosqlx version <tag>.
• .goreleaser.yml: removed -X main.version={{.Version}}. GoReleaser only builds examples/sql-validator and examples/sql-formatter, and neither defines main.version, so the flag did nothing.
• test.yml (Scorecard alert feat(#249): Dialect mode engine (Phase 1) #315, "goCommand not pinned by hash" at line 133): the README quickstart job used go get ...@latest without a pinned version. It now finds the latest tag with go list -m ...@latest, logs it, pins it with go mod edit -require, then runs go mod tidy, which checks the module against sum.golang.org. The job still tests the newest tagged release.

Design decisions (scoped worker, conservative choice)

• No cmd/gosqlx build was added to GoReleaser. That would change the release asset set (gosqlx_tools_* archives) during a release hold. If you want the CLI in GitHub release archives, add it in a later PR with the same -X .../cmd.Version={{.Version}} ldflag.
• gosqlx-mcp: its version comes from gosqlx.Version, a const in pkg/gosqlx that -X cannot override. It is not built with ldflags anywhere (deploy-mcp builds from source at the tagged commit). It already reports the library version, which PR docs(release): prepare v1.16.0 #845 bumps. I left it alone because changing the public const to a var would break the API.
• root.go: I set rootCmd.Version in init() and did not edit the Version: "1.14.0" literal, so this PR does not conflict with the release PR docs(release): prepare v1.16.0 #845, which edits that line. The literal is now overridden at init. Removing it later is optional cleanup.

Code-scanning alerts left open (no upstream fix, or repo settings outside this PR's scope)

• FEAT-012: Schema-Aware Validation #82 Vulnerabilities: GO-2026-5932 (golang.org/x/crypto/openpgp is unmaintained; no fixed version), GHSA-vfj7-8cjw-p6xm (braces, last affected 3.0.3, no fix), GHSA-hp3w-g68c-fv3c (sprintf-js, last affected 1.1.3, no fix).
• FEAT-011: Query Optimization Suggestions #81 CodeReview, FEAT-009: Additional SQL Dialects (Snowflake, BigQuery, Redshift) #80 CII Best Practices, CLI-009: Language Server Protocol (LSP) Implementation #76 Branch Protection: these depend on repo or account settings or process, and this task is not allowed to change them.

Test Plan

• gofmt, go vet, golangci-lint run ./pkg/lsp/... ./cmd/gosqlx/... (0 issues)
• go test -race ./pkg/lsp/ ./cmd/gosqlx/... passes. New assertions: initialize returns gosqlx.Version (pkg/lsp/server_test.go), and rootCmd.Version == Version (cmd/gosqlx/cmd/version_test.go)
• go build ./cmd/gosqlx && ./gosqlx --version prints gosqlx version 1.14.0 (the dev default)
• go build -ldflags "-s -w -X github.com/ajitpratap0/GoSQLX/cmd/gosqlx/cmd.Version=9.9.9" prints gosqlx version 9.9.9. A Windows cross-compile with the same ldflags also builds.
• Ran the new test.yml quickstart steps locally: resolved v1.15.0, then build and run succeeded
• All three YAML files parse. GoReleaser is not installed locally, so I ran no goreleaser check. The YAML change only removes the ldflag argument.
• CI green

Breaking Changes

None. LSP clients now see the real library version in serverInfo.version instead of 1.0.0.

Release note

• Fixed: the LSP server now reports the GoSQLX library version in serverInfo.version instead of a hard-coded 1.0.0. The gosqlx binary bundled with the VS Code extension now prints the release tag from gosqlx --version. The CLI version can be stamped at build time with -ldflags "-X github.com/ajitpratap0/GoSQLX/cmd/gosqlx/cmd.Version=<version>".

🤖 Generated with Claude Code

https://claude.ai/code/session_01RkzVu3JY9Y6BRWfjesWts9

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
gosqlx-website	Ignored		Oct 21, 2026 6:05pm UTC

[github-actions]

Claude finished @ajitpratap0's task in 23s —— View job

---

Review of PR #846

The change is small, correct and well scoped. I found no blocking issues. I read the diff and the Version declarations in root.go and pkg/gosqlx. I did not run the tests or the workflows.

What I checked

• LSP: gosqlx.Version is a const, and pkg/lsp already imports gosqlx, so there is no new import cycle. The new assertion in server_test.go covers the change.
• CLI: Version is a var string (root.go:46), so -X ...cmd.Version= works. Setting rootCmd.Version in init() overrides the "1.14.0" literal at root.go:134, and cobra's default template prints gosqlx version <v>. That matches the smoke-test comparison.
• vscode-publish.yml: the tag goes in through env rather than inline ${{ }} in the script, which avoids script injection. The semver check is strict (X.Y.Z), so it would fail on tags like v1.15.0-rc1. That is reasonable for a publish job, but you should know it's there.
• .goreleaser.yml: removing the no-op -X main.version flag is harmless.
• test.yml: go list -m ...@latest followed by go mod edit -require and go mod tidy is sound. @latest excludes pre-releases. The version is resolved in the same step, so this is only partly pinned, but it does satisfy the Scorecard check, and the logged tag helps debugging.

Minor suggestions (non-blocking)

1. Version duplication: Version in root.go, Version: "1.14.0" at root.go:134, and gosqlx.Version are three separate copies that can drift. A test asserting cmd.Version == gosqlx.Version would catch drift on release bumps. This would fail on a mismatched bump, which is the intent. Alternatively, drop the literal at root.go:134 after docs(release): prepare v1.16.0 #845 merges, as you noted.
2. Smoke test scope: it only runs on linux-x64. That is fine, since the same -X flag applies to every target.
3. Test strength: TestRootCmdVersionUsesVersionVar checks rootCmd.Version == Version, which is nearly tautological after init(). Consider also executing rootCmd with --version and checking the output contains Version. That would guard the gosqlx version X format the smoke test relies on.
4. Merge order: the release PR docs(release): prepare v1.16.0 #845 edits root.go:134 and the bumped constants. The merge should be clean, but check Version and gosqlx.Version still agree afterwards.

Test coverage: adequate for the change. The CI-workflow changes can only be validated by running them, so the unchecked "CI green" item is the remaining gate.

LGTM pending CI.