[ajitpratap0]

Summary

Follow-up to #851, addressing the two low-severity review notes left open:

1. release.yml previous-tag lookup could pick the v1 Marketplace tag. git describe --match 'v[0-9]*' matches the floating major tag v1 (moved with git tag -fa v1 per MARKETPLACE_PUBLISHING.md). If it ever sits closer than the last real release, GoReleaser would build the changelog and compare link against it. The match is now v[0-9]*.[0-9]*.[0-9]*, which covers all 27 existing release tags and excludes v1.
2. Installing from the sdist on an unsupported platform silently produced a broken package. On musl/32-bit, pip builds a wheel from the sdist without libgosqlx, caches it and installs it; the only signal was a stderr warning pip hides by default, and pygosqlx failed at first use. PlatformWheel.run now fails the build with an actionable error. PYGOSQLX_ALLOW_MISSING_LIB=1 opts back into the old behaviour for users who supply GOSQLX_LIB_PATH at runtime. README documents it.

Test Plan

• git tag -l 'v[0-9]*.[0-9]*.[0-9]*' → 27 tags, all vX.Y.Z; v1 excluded (old pattern included it).
• sdist → pip wheel with no library: fails with the new error message.
• Same with PYGOSQLX_ALLOW_MISSING_LIB=1: builds.
• pip install -e "python[dev]" without the library (Python CI path): unaffected (editable builds don't run bdist_wheel).
• Built libgosqlx.dylib, pip install python/, pytest: 184 passed, 3 skipped.
• cibuildwheel jobs always build the library first (CIBW_BEFORE_BUILD_*), so release wheels are unaffected; CI on this PR confirms.

Breaking Changes

None for supported platforms. On platforms without a prebuilt wheel, pip install pygosqlx now errors at build time instead of installing a package that cannot load.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RkzVu3JY9Y6BRWfjesWts9

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
gosqlx-website	Ignored	Preview	Oct 22, 2026 10:02am UTC

[github-actions]

Claude finished @ajitpratap0's task in 23s —— View job

---

Review of PR #852

Both changes are small and correct. I only read the diff and ran nothing.

release.yml: tag match

• v[0-9]*.[0-9]*.[0-9]* is a git glob, where * also matches .. It therefore excludes v1 and v1.2, and still matches prerelease tags such as v1.14.0-rc1.
• It also keeps ignoring pygosqlx-* tags. The added comment explains why.

python/setup.py: fail the build when the library is missing

• Failing in bdist_wheel.run is the right place. It fits what you tested: editable installs and cibuildwheel, which builds the library first, are unaffected.
• Nit, lint: the diff removes one of the two blank lines before setup(...), so there is now only one. flake8 E305 and black will flag this if Python lint runs on python/. Restore the second blank line.
• Nit, exception type: raise SystemExit(f"error: ...") works, and pip shows the message. Raising distutils.errors.DistutilsSetupError (or setuptools.errors.BaseError) is the more conventional way to fail a setuptools command. It also avoids unwinding through a backend that might catch SystemExit differently. Not blocking.
• The check only looks at _LIB_DIR for .so, .dylib or .dll. It does not check that the extension matches the current platform, so a stale .dylib left in lib/ on Linux would pass. This was already the case before the PR, and the build.sh flow makes it unlikely.
• PYGOSQLX_ALLOW_MISSING_LIB must be exactly "1". That's fine, and the README says so. It's worth noting that pip passes the environment through to the isolated build, so the opt-in works with pip install.

python/README.md

• The sentence ending "set PYGOSQLX_ALLOW_MISSING_LIB=1 for the install and:" runs into a code block that only shows export GOSQLX_LIB_PATH=.... Consider showing both variables in the block, for example:

  PYGOSQLX_ALLOW_MISSING_LIB=1 pip install pygosqlx
  export GOSQLX_LIB_PATH=/path/to/libgosqlx.so

Tests

• Your manual checks cover the new behavior. There is no automated test for the "missing library → error, and the env var → warning" paths. A small pytest that runs bdist_wheel on a temp copy with lib/ empty would guard against regressions. It's optional, since the CI wheel jobs only exercise the success path.

Security and performance: nothing to flag.

Overall this is good to merge after the blank-line fix.
· branch fix/release-tag-match-and-sdist-guard

[github-actions]

Claude finished @ajitpratap0's task in 20s —— View job

---

Review of PR #852

I read the full diff against origin/main and ran nothing.

Previous nits are addressed

• The README block now shows both PYGOSQLX_ALLOW_MISSING_LIB=1 pip install pygosqlx and export GOSQLX_LIB_PATH=....
• The blank-line change from the last commit is in. The setup.py diff no longer touches the lines before setup(...).

release.yml

• v[0-9]*.[0-9]*.[0-9]* excludes v1 and pygosqlx-* tags. It still matches prerelease tags such as v1.14.0-rc1.
• The comment explains why the pattern has two dots.

python/setup.py

• Failing in bdist_wheel.run is the right place. Editable installs and cibuildwheel, which builds the library first, are unaffected.
• The message names the cause, the fix and the opt-in. In the ALLOW_MISSING_LIB=1 case it keeps the old warning.
• Non-blocking: raise SystemExit(...) works, but setuptools.errors.BaseError or distutils.errors.DistutilsSetupError is the more conventional way to fail a setuptools command. A backend that catches SystemExit could handle it differently.
• Non-blocking: the check only looks for any of .so, .dylib or .dll in lib/. It doesn't check that the extension matches the platform, so a stale library of the wrong type would pass. That was already true before this PR.
• Non-blocking: the opt-in needs exactly "1". The README says so, so that's fine.

Tests

• There is no automated test for the "missing library raises" path or the opt-in path. Your manual checks cover them. A small pytest that runs bdist_wheel on a temp copy with lib/ empty would guard against regressions, but I don't think it's needed to merge.

Security and performance: nothing to flag.

Overall this looks good to merge.
· branch fix/release-tag-match-and-sdist-guard