Repository navigation
ci: let the deploy job publish to PyPI with trusted publishing - #961
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Grant id-token: write to the deploy job, which runs devenv-pypi after the image manifest. devenv-pypi now publishes with PyPI trusted publishing once the PYPI_TOKEN secret is deleted, and that needs the job to be able to get a GitHub identity token. While the secret exists it still publishes with the token. A new test pins the permission. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is Phase 2 of moving PyPI publishing to trusted publishing (OIDC).
devenv-pypiaction from ajslater/devenv#20.uv publish --trusted-publishing always.deployjob: now grantsid-token: write, alongsidecontents: readandpackages: write. PyPI still publishes after the image manifest. The job keeps passingsecrets.PYPI_TOKEN, so nothing changes until that secret is deleted. After that, it publishes with trusted publishing, using the publisher already registered on PyPI (ajslater/codex,ci.yml).tests/test_ci_workflow.py: a new test pins the permission.Known pre-existing lint failure (not from this PR)
make lintfails in vulture onnode_modules/katex/src/fonts/generate_fonts.py, and it fails the same way on develop.micromark-extension-math.excludepatterns against absolute file paths, so devenv's**/node_modulespattern never excluded anything.*/node_modules/*. With that exclude, vulture passes here.The Lint combo in this PR's CI will be red until that fix reaches codex through
update-devenv.Test plan
make test: 1575 passed, 1 xfailed.actionlintis clean.make lintpasses except for the pre-existing vulture issue above.PYPI_TOKEN. The next publish should log trusted publishing.🤖 Generated with Claude Code