Skip to content

fix(x/deployment): skip non matching denom during migration#2058

Merged
troian merged 1 commit intomainfrom
denom
Mar 23, 2026
Merged

fix(x/deployment): skip non matching denom during migration#2058
troian merged 1 commit intomainfrom
denom

Conversation

@troian
Copy link
Member

@troian troian commented Mar 23, 2026

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Signed-off-by: Artur Troian <troian@users.noreply.github.com>
@troian troian requested a review from a team as a code owner March 23, 2026 13:01
@coderabbitai
Copy link

coderabbitai bot commented Mar 23, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 352bcd6d-2298-4c0e-8ee8-3863fe4509fd

📥 Commits

Reviewing files that changed from the base of the PR and between 2d606d3 and 6e1addd.

📒 Files selected for processing (1)
  • x/deployment/keeper/abci.go

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


Walkthrough

A denom-consistency guard was added to the EndBlocker's pendingDenomMigrations loop in x/deployment/keeper/abci.go. After migration execution, the code now validates that the returned source coin's denom matches the expected burn coin's denom, halting processing if they diverge.

Changes

Cohort / File(s) Summary
Denom Consistency Guard
x/deployment/keeper/abci.go
Added validation check to ensure srcCoin.Denom matches burnCoin.Denom after migration execution; returns early without error on mismatch to prevent accumulating coins with unexpected denoms.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A denom so fickle, a coin out of place,
Now checked with precision, with guard-rail grace,
When denominations drift and stray,
Our bunny says "nope!" and calls it a day! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch denom

Comment @coderabbitai help to get the list of available commands and usage tips.

@troian troian merged commit 408af15 into main Mar 23, 2026
2 of 3 checks passed
@troian troian deleted the denom branch March 23, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant