Skip to content

backport: preserve server compatibility on 2.91.3 - #14

Merged
jack-o-mania merged 10 commits into
releases/v2.91.0from
backports/v2.91.0/server-compatibility
Oct 31, 2026
Merged

jack-o-mania merged 10 commits into
releases/v2.91.0from
backports/v2.91.0/server-compatibility

Conversation

@jack-o-mania

@jack-o-mania jack-o-mania commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Build the approved 2.91.0 release line with the three compatibility fixes already deployed on the server: list stored Codex pool accounts when the native home is absent, accept ingress-validated Hub bearer admission for search, and remember a validated dashboard admin login for one year.

This carries the original commits and authorship from #1, #3, and the remembered-login source used by #12. Version mirrors advance once per feature (2.91.1, 2.91.2, 2.91.3) on the fixed releases/v2.91.0 branch. It also carries the previously merged fork release/PR-target policy required to validate that branch. The runtime dependency lockfiles remain at upstream 2.91.0.

The GUI behavior matches the deployed source change; its existing login form evidence is shown here:
Admin-login form from the source change

Verification

  • bun run typecheck: passed.
  • Focused headless-account, search-admission, layout, file-size, and release-version gates: all passed. The layout-tooling subprocess requires the repository's Bun 1.4.3 test pin; that gate passed after supplying the pinned runner.
  • cd gui && bun test --isolate tests: 3,507 passed, zero failures.
  • GUI lint and production build: passed.
  • Documentation site build: passed (593 pages, 84,780 internal links).
  • bun run structure:check, bun run privacy:scan, PR-target policy tests, bun run prepare:package, and four-file version synchronization check: passed.
  • git diff --check: passed.

The full runtime suite is left to PR CI under the documented shared-host resource exception. Focused runtime tests cover the two changed admission/account paths, unsafe and missing homes, credential preservation, denied credentials/scopes, correct stored-account selection, and preventing Hub keys from being forwarded. The full GUI suite covers the remembered-token expiry, validation, logout, origin isolation, and stale-response behavior. No production activation occurs before this PR and the upstream-sync prerequisite are reviewed and merged.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults (Codex code and explicit security reviews completed clean on the current head).

Co-authored-by: Alex aleks00799@gmail.com
Co-authored-by: Aleksei Chistiakov aleks00799@gmail.com
Co-authored-by: jack-o-mania aleks00799+jack@gmail.com
Co-authored-by: Codex codex@localhost

alexalok and others added 10 commits October 31, 2026 10:49
Keep stored ChatGPT pool accounts visible and refreshable when the native Codex home is proven absent. Preserve native identity and reauthentication state without creating a home or relaxing credential-mutation claims.

Validate OpenCodex storage before the missing-home fallback, and surface invalid home-resolution failures. Add isolated regressions for list/refresh routes and synchronize account-list guidance across all published locales.

(cherry picked from commit 4abfcc6)
(cherry picked from commit ea3e96f)
(cherry picked from commit be4f7a7)
(cherry picked from commit 4d73fac)
(cherry picked from commit 001eb14)
(cherry picked from commit 299e471)
* fix(search): accept validated Hub bearer admission

* test(search): shard admission layout registration

* test(search): align Reserve ingress with Hub bearer admission

---------

Co-authored-by: Codex <codex@localhost>
(cherry picked from commit f9206d4)
(cherry picked from commit c7014ad)
(cherry picked from commit 733583f8d4cf687eef5c0059c2010e106e5482f3)
(cherry picked from commit c0263ad)
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T11:01:14.244019Z 427f1b4 PR opened
🔒 Security Review ✅ Completed 2026-10-31T11:03:32.361171Z 427f1b4 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Oct 31, 2026
@jack-o-mania

Copy link
Copy Markdown
Collaborator Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 427f1b4d2b

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@jack-o-mania
jack-o-mania merged commit faa77b9 into releases/v2.91.0 Oct 31, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants