Repository navigation
backport: carry fork release fixes onto v2.93.0 as 2.93.3 - #17
Conversation
(cherry picked from commit 860d501)
* fix(search): accept validated Hub bearer admission * test(search): shard admission layout registration * test(search): align Reserve ingress with Hub bearer admission --------- Co-authored-by: Codex <codex@localhost> (cherry picked from commit f9206d4) (cherry picked from commit c7014ad) (cherry picked from commit 354ead9)
(cherry picked from commit cbc48e3)
github-actions
Bot
added
the
intake: hygiene-blocked
|
|
grok review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
removed
the
intake: hygiene-blocked
|
grok review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 620b99717f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![grok-o-mania[bot]](https://avatars.githubusercontent.com/in/5508847?s=60&v=4){kind=small}
There was a problem hiding this comment.
Grok review (620b997).
Backports the fork's 2.91.x changes onto releases/v2.93.0 as 2.93.3: the fork-only backport target rule in enforce-pr-target.yml (same-repo backports/vX.Y.Z/* into the matching releases/vX.Y.Z, no main compare in the fork), fork-scoped release tag ancestry via package.json.opencodexFork, standalone search skipping the forwarding guard only for an ingress-validated bearer admission (the sidecar resolver still substitutes stored credentials), a one-year remembered admin token in localStorage that is saved only after server validation and cleared on 401, expiry, or logout, IPv4 loopback aliases counting as trusted management locality without exempting data-plane API keys, plus the matching docs, structure entries, version mirrors and tests.
No issues found. Checked for bugs and AGENTS.md compliance.
|
grok review |
A standalone or Hub dashboard that requires the admin token remembers it for a year, but both sign-out buttons were gated on a minted ocx_session_ credential. The remembered token could only be removed by clearing browser data. Show the control for typed admin-token logins as well and wire it to the existing remembered-token cleanup.
|
@codex review |
|
grok review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
grok review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
grok review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Leaves the remembered-login test file identical to the 2.91 line so the retained local remembered-admin-login patch still verifies against this release.
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
grok review |
Summary
Moves the fork's release line to upstream v2.93.0 (the newest stable release at least seven full days old) and carries the fork's deployed 2.91.x changes onto it, producing 2.93.3. Version mirrors advance once per feature on the fixed
releases/v2.93.0branch.The stored-pool-accounts fix from the 2.91 line is not carried because upstream already ships it in 2.93.0 (lidge-jun#7551).
The GUI behavior matches the remembered-login change already shipped on the 2.91 line; its existing login form evidence is shown here:
Verification
bun run typecheckwith pinned Bun 1.4.4: passed.tests/api-auth-memory.test.ts(14 tests) and GUI production build: passed.The full suite is left to PR CI.
Checklist
Co-authored-by: Aleksei Chistiakov aleks00799@gmail.com
Co-authored-by: jack-o-mania aleks00799+jack@gmail.com
Co-authored-by: Codex codex@localhost