Repository navigation
ci: skip hosted macOS jobs in the alexalok/opencodex fork - #19
Conversation
|
@codex review |
|
grok review |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![grok-o-mania[bot]](https://avatars.githubusercontent.com/in/5508847?s=60&v=4){kind=small}
There was a problem hiding this comment.
Grok review (67ae250).
This PR gates every hosted macOS job and matrix leg on github.repository != 'alexalok/opencodex' so the fork stops queueing macOS runners: platform-macos, widget, macos-control and macos-launchd are skipped, and the macOS legs of setup-action, remote-helper, codex-queue-helpers, catalog-async-contracts and the emitted keyring/npm-global smoke matrices are dropped. The ci aggregate gate reads the same switch through MACOS_ENABLED, so it expects not-requested for those jobs in the fork (the only job that needs them), and upstream behavior is unchanged. Tests are updated for the new conditions plus fork-specific matrix and gate coverage.
No issues found. Checked for bugs and AGENTS.md compliance.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67ae250064
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
grok review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
grok review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
Hosted macOS jobs never get a runner in
alexalok/opencodex. On #18,queue helpers (macos-latest)sat in the queue until its 10-minute limit twice, with no runner assigned and no steps run, so the check failed without testing anything. This change stops the fork's automatic runs (pull requests, pushes and the nightly schedule) from requesting hosted macOS runners. A manualworkflow_dispatchin the fork still runs every macOS job, so macOS validation remains available on demand. Upstream behavior stays the same.Each macOS job or leg is gated on
(github.repository != 'alexalok/opencodex' || github.event_name == 'workflow_dispatch'):ci.yml:platform-macos(4 shards),macos-controlandwidgetare skipped. The macOS legs ofsetup-actionandremote-helperare dropped, and so are the macOS legs of thekeyring-smokeandnpm-global-smokematrices that thechangesjob emits. Theciaggregate gate reads the same switch (MACOS_ENABLED) and expectsnot-requestedfor those jobs in the fork, so the nightly run does not demand jobs that were never scheduled.codex-queue-helpers.yml: the matrix drops themacos-latestleg in the fork. This is the only macOS leg that ran on pull requests.catalog-async-contracts.yml: the matrix drops the macOS leg after merge in the fork.service-lifecycle.yml:macos-launchdis skipped in the fork.release.ymland the self-hosteddesktop-installed-gate.ymlare unchanged, because the fork does not publish releases.Verification
bun test tests/ci-workflows/: 1829 passed, 1 failed. The failure isbundledBunPath / durableBunPath > PATH-selected process provenance, which fails the same way on unmodifieddevwith the local Bun install.if:and matrix expectations. Added coverage showing that the fork's emitted smoke matrices have no macOS leg on push or the schedule and keep it on dispatch, that the aggregate gate expects the macOS jobs to be skipped in the fork outside dispatch, and that a fork push or schedule leavesplatform-macosandwidgetunselected while a fork dispatch selects them.bun scripts/structure-ssot.ts: passed. Every workflow file parses as YAML.Checklist