Repository navigation
Conversation
ModuleExecutionList and ModuleBuildList rendered every entry. With 10,000 executions, Build History created 10,003 rows (130,189 DOM elements) and froze the browser. Both lists now show one page of module.entriesperpage rows, with a first/previous/next/last pager. The Build History scroll area capped its root height but not its viewport, so rows past about 500 px were clipped and could not be scrolled to. The cap now applies to the viewport. Adds an npm test script that runs the paging tests with node --test.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Svelte client rendered every row of the Build History (execution list) and Build Library (build list). With 10,000 executions, opening Build History blocked the browser for tens of seconds. It also ignored the list's
entriesperpagesetting, which the server sends and core already parses (default 25). Both lists now render one page at a time.The pager also exposed a bug in the execution list. Its
ScrollAreasetmax-h-[500px]on the root, but the viewport issize-full, so it never scrolled. Rows past about 500 px were clipped and could not be reached. The cap now applies to the viewport (*:data-[slot=scroll-area-viewport]:max-h-[500px]).Evidence
Checked in Chromium against a server with 10,002 executions and 43 builds, with
entriesperpage="20".<tr>and 130,189 DOM elements, and the main thread is blocked until the first row appears. Build Library renders all 43 rows. Neither list has a pager.After: Build History renders 20 rows and 440 DOM elements, showing "1–20 of 10002" (1 / 501). Build Library shows "1–20 of 43" (1 / 3). First, previous, next and last work on both, and the last page of Build History shows the remaining 2 rows. The pager is visible and clickable at 1280×800 and 800×480.
After: the viewport is 500 px and scrolls to the last row.
npm test, 4/4 passing:npm run check: adds no errors.developcannot currently build the Svelte client, becauseClient/core/common/AMCListDeltaSync.jsis imported but was never committed. These checks used a local copy of that file. It is not part of this PR.Merge Danger
Door: two-way
This is client-only, with no server, API or data changes, and a revert removes it completely.
Blast Radius: layout
entriesperpageis configured, instead of everything at once.