Repository navigation
Conversation
GCC 15's libstdc++ no longer pulls <cstdint> in transitively via <memory>, <string> and friends, so every header that names uint32_t/uint64_t without including it fails to compile. 76 headers under Implementation/ and ten driver headers (ADS, A3200, BuR journal group/value, CifX, Euler, Marlin serial controller, Pylon, Rasterizer algorithm, RayLase) relied on that transitive include; each now includes <cstdint> directly. Separately, GCC 15 defaults to C23, where "bool" is a keyword, which rejects the vendored libzip's "typedef ... bool" in zipint.h. Pin CMAKE_C_STANDARD to 17.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developdoes not compile with GCC 15:<cstdint>: GCC 15's libstdc++ no longer pulls in<cstdint>transitively through<memory>,<string>and similar headers. Every header that usesuint32_t/uint64_twithout including it fails, for examplecommon_exportstream.hpp:44: error: 'uint64_t' has not been declared.boolis a keyword. That breaks the vendored libzip'stypedef ... boolinzipint.h.Fix:
#include <cstdint>in the 76 headers underImplementation/and the 10 driver headers that rely on the transitive include (ADS, A3200, BuR journal group/value, CifX, Euler, Marlin serial controller, Pylon, Rasterizer algorithm, RayLase).set (CMAKE_C_STANDARD 17)inCMakeLists.txt.There are no functional changes. Older compilers are unaffected:
<cstdint>is standard C++11, and the C code already targets C17 or earlier.Evidence
GCC 15.2.0 (Ubuntu 15.2.0-16ubuntu1),
./build_clean_linux64.shwith default options (drivers included), no extra compiler flags:build_resourceswith'uint64_t' has not been declarederrors.Merge Danger
Door: two-way
Blast Radius: build only (include lines and the C standard setting)