Repository navigation
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84064f1bde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
JHWang-1997
left a comment
There was a problem hiding this comment.
Reproduced one remaining P2 in independent OpenCode judge initialization: omitting judge.engine.model.base_url leaves the runner’s provider endpoint active. The inline comment includes a minimal setup, expected/actual behavior, and a passing explicit-endpoint control.
|
Addressed the default-endpoint routing review in f61c678 and synchronized #315/#316. Regression tests, real OpenSandbox default-configuration readback, and the live explicit-endpoint judge control passed. Native OpenAI connectivity remains a separately documented limitation. Details are in the inline reply. Please re-review the updated stack. |
Summary
An
agent_judgecurrently inherits the evaluated agent's engine even when its model requires another protocol. Add an explicitjudge.engineusing the existing engine schema so a Codex runner can be reviewed by Claude Code, with independently resolved model connections and adapter settings. Legacyjudge.modelremains supported.Related issues
Fixes #104. First of the three proposed changes; Shared-runtime Docker/OpenSandbox judging follows in #315 and #316; #308 remains separate.
Changes
Test plan
make fmtmake verify(0 lint issues)make test(race detector, plugin tests, Skill regression scripts)go run ./cmd/skill-up validate ./examples/code-stats/evals/eval.yamlProvider configuration regression
Default-endpoint follow-up: