fix: prevent infinite recursion in update_forward_refs for self-referencing DTOs#10
Merged
Merged
Conversation
…encing DTOs Add _visited set to track already-processed types, breaking recursion cycles when a DefineSubset DTO references itself (e.g. replies: list["CommentDTO"]).
- Add missing UseCaseService import in voyager_context.py - Replace mutable default `tags: list[str] = []` with `None` in test - Apply ruff auto-fixes: unused imports, blank lines, getattr simplification 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…ault fix 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
update_forward_refsintype_helper.pyrecurses infinitely when a DefineSubset DTO references itself (e.g.replies: list["CommentDTO"]).Root Cause
No visited-set — self-referencing types cause unbounded recursion through field annotations.
Fix
Added
_visited: set | None = Noneparameter to track already-processed types. On re-encounter, the type is skipped sincemodel_rebuild()already resolved its forward refs on the first visit.Changed Files
src/sqlmodel_nexus/voyager/type_helper.py— add visited-set guard (+5 lines)tests/test_voyager_selfref.py— flip test frompytest.raises(RecursionError)to assert normal completion