Skip to content

Report the offending aligned-indent option value #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muneikh wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

Report the offending aligned-indent option value #933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlparse/formatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def validate_options(options):
reindent_aligned = options.get('reindent_aligned', False)
if reindent_aligned not in [True, False]:
raise SQLParseError('Invalid value for reindent_aligned: '
f'{reindent!r}')
f'{reindent_aligned!r}')
elif reindent_aligned:
options['strip_whitespace'] = True

Expand Down
9 changes: 9 additions & 0 deletions tests/test_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@


class TestFormat:
@pytest.mark.parametrize('reindent', [True, False])
@pytest.mark.parametrize('aligned', ['invalid', None, 2])
def test_reindent_aligned_invalid_option_diagnostic(self, reindent, aligned):
with pytest.raises(SQLParseError) as exc:
sqlparse.format('select 1', reindent=reindent,
reindent_aligned=aligned)
assert str(exc.value) == (
f'Invalid value for reindent_aligned: {aligned!r}')

def test_keywordcase(self):
sql = 'select * from bar; -- select foo\n'
res = sqlparse.format(sql, keyword_case='upper')
Expand Down