Skip to content

fix(@angular/build): alias createRequire banner import to avoid duplicate binding #32765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arturovt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(@angular/build): alias createRequire banner import to avoid duplicate binding #32765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/angular/build/src/tools/esbuild/application-code-bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,14 @@ export function createServerPolyfillBundleOptions(
if (isNodePlatform) {
// Note: Needed as esbuild does not provide require shims / proxy from ESModules.
// See: https://github.com/evanw/esbuild/issues/1921.
// Use an alias to avoid colliding with any `createRequire` import that may
// already exist in the bundled user code. ESBuild processes banner content
// as raw text outside of its module graph, so it cannot deduplicate or
// rename banner imports the way it does for user imports. Without the alias,
// a duplicate `import { createRequire }` binding would cause a runtime error.
jsBanner.push(
`import { createRequire } from 'node:module';`,
`globalThis['require'] ??= createRequire(import.meta.url);`,
`import { createRequire as __ngCreateRequire } from 'node:module';`,
`globalThis['require'] ??= __ngCreateRequire(import.meta.url);`,
);
}

Expand Down Expand Up @@ -397,9 +402,14 @@ export function createSsrEntryCodeBundleOptions(
if (isNodePlatform) {
// Note: Needed as esbuild does not provide require shims / proxy from ESModules.
// See: https://github.com/evanw/esbuild/issues/1921.
// Use an alias to avoid colliding with any `createRequire` import that may
// already exist in the bundled user code. ESBuild processes banner content
// as raw text outside of its module graph, so it cannot deduplicate or
// rename banner imports the way it does for user imports. Without the alias,
// a duplicate `import { createRequire }` binding would cause a runtime error.
jsBanner.push(
`import { createRequire } from 'node:module';`,
`globalThis['require'] ??= createRequire(import.meta.url);`,
`import { createRequire as __ngCreateRequire } from 'node:module';`,
`globalThis['require'] ??= __ngCreateRequire(import.meta.url);`,
);
}

Expand Down
Loading