refactor: use field backing property in Instant Editor VM#20501
Merged
david-allison merged 1 commit intoankidroid:mainfrom Apr 5, 2026
Merged
refactor: use field backing property in Instant Editor VM#20501david-allison merged 1 commit intoankidroid:mainfrom
david-allison merged 1 commit intoankidroid:mainfrom
Conversation
89eadf4 to
1e89db3
Compare
1e89db3 to
49c005d
Compare
5 tasks
david-allison
approved these changes
Apr 5, 2026
Member
david-allison
left a comment
There was a problem hiding this comment.
Might have wanted a [delegated] property on currentClozeNumber, but seems OK to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Use the new field backing property in the ViewModels in our codebase
Fixes
NA
Approach
Replace the existing code
_somethingwithfieldand update the usageThe commits are clear as to what VM I touched and what I changed
How Has This Been Tested?
Local compile and tested the changes on my Pixel
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.