Skip to content

refactor: use field backing property in Instant Editor VM#20501

Merged
david-allison merged 1 commit intoankidroid:mainfrom
criticalAY:fieldbacking/InstantEditorVM
Apr 5, 2026
Merged

refactor: use field backing property in Instant Editor VM#20501
david-allison merged 1 commit intoankidroid:mainfrom
criticalAY:fieldbacking/InstantEditorVM

Conversation

@criticalAY
Copy link
Copy Markdown
Contributor

Purpose / Description

Use the new field backing property in the ViewModels in our codebase

Fixes

NA

Approach

Replace the existing code _somethingwith field and update the usage
The commits are clear as to what VM I touched and what I changed

How Has This Been Tested?

Local compile and tested the changes on my Pixel

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY criticalAY added Blocked by dependency Currently blocked by some other dependent / related change and removed Needs Review labels Mar 16, 2026
@criticalAY criticalAY marked this pull request as draft March 16, 2026 21:43
@lukstbit lukstbit added Needs Author Reply Waiting for a reply from the original author and removed Blocked by dependency Currently blocked by some other dependent / related change labels Mar 24, 2026
@criticalAY criticalAY force-pushed the fieldbacking/InstantEditorVM branch from 89eadf4 to 1e89db3 Compare April 5, 2026 03:34
@criticalAY criticalAY force-pushed the fieldbacking/InstantEditorVM branch from 1e89db3 to 49c005d Compare April 5, 2026 03:38
@criticalAY criticalAY removed the Needs Author Reply Waiting for a reply from the original author label Apr 5, 2026
@criticalAY criticalAY marked this pull request as ready for review April 5, 2026 03:38
@criticalAY criticalAY changed the title refactor: use field backing property in VMs refactor: use field backing property in Instant Editor VM Apr 5, 2026
@criticalAY criticalAY mentioned this pull request Apr 5, 2026
5 tasks
Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have wanted a [delegated] property on currentClozeNumber, but seems OK to me

@david-allison david-allison added this pull request to the merge queue Apr 5, 2026
Merged via the queue into ankidroid:main with commit 5746faf Apr 5, 2026
15 checks passed
@github-actions github-actions Bot added this to the 2.24 release milestone Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants