Enhance Add Note Type dialog styling and validation by Chaos10001 · Pull Request #20512 · ankidroid/Anki-Android

Chaos10001 · 2026-03-18T19:57:05Z

Purpose / Description

This PR modernizes the Add Note Type dialog by replacing outdated UI components with Material Design elements and introducing real-time validation. These changes provide immediate feedback to the user and align the dialog with modern Android design standards.

Fixes

Fixes Improve the "Add note type" dialog #20466

Approach

Changes

UI Modernization
(i) Material Components: Replaced the standard EditText with TextInputLayout using the OutlinedBox style. This adds a professional border and a floating "Name" label.

(ii) Copy Updates: Changed dialog title from "Type" to "Add note type".
· Updated confirmation button from "OK" to "Add" for better intent clarity.

Validation Logic & Feedback
(i)Real-time Detection: Implemented an addTextChangedListener to compare user input against existing note type names.

(ii)Error Handling: Utilized TextInputLayout.setError() to trigger a red border and a "This note name already exists" message when a duplicate is detected.

(iii)State Management: The "Add" button is now dynamically disabled while a validation error is present.

How Has This Been Tested?

Device: Techno spark 30

Test Steps:

Navigate to the Manage Note Types screen.
Tap the + button to open the new dialog.
Verification: Confirmed the title displays "Add note type".
Duplicate Test: Entered an existing name (e.g., "Basic").
· Result: Border turned red; error message appeared; "Add" button disabled.
Unique Test: Entered a new, unique name.
· Result: Error cleared; "Add" button enabled.

github-actions · 2026-03-18T19:57:16Z

Important

Maintainers: This PR contains Strings changes

Sync Translations before merging this PR and wait for the action to complete
Review and merge the auto-generated PR in order to sync all user-submitted translations
Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

ZornHadNoChoice · 2026-03-19T11:12:20Z

It's up to the maintainers to decide which PR to merge, but please read my comment here #20479 (comment) and additionally, reduce the vertical padding in the dialog.

david-allison · 2026-03-20T00:24:35Z

Lint is failing

https://github.com/ankidroid/Anki-Android/tree/main/.github/workflows#quality-checks

Chaos10001 · 2026-03-20T20:18:44Z

@david-allison Lint issue resolved

david-allison

Thanks!!!!!

The padding of the dialog doesn't match the spec: https://m3.material.io/components/dialogs/specs

Please note my review comments on: #20479, s there may be additional useful context

All minor issues, should be good to get this in 👍

david-allison · 2026-03-20T23:16:04Z

    <string name="model_field_editor_reposition_menu">Reposition field</string>
    <string name="model_field_editor_changing">Updating fields</string>
    <string name="model_field_editor_sort_field">Sort by this field</string>
+    <string name="model_editor_name">Name</string>


make this generic, move it out the file and use name="name_prompt"

david-allison

Whoops, forgot to submit this.

A before/after screenshot would be great! Last round 🤞.

I'll get it over the finish line if it needs more, it's ALMOST done 👍

Chaos10001 · 2026-03-22T09:08:03Z

Before

After

david-allison · 2026-03-22T13:23:45Z

Last one I think!

david-allison · 2026-03-22T19:52:24Z

+            // Previously used inconsistent padding (32/64dp) that didn't follow the spec.
+            // See: https://m3.material.io/components/dialogs/specs


I thought the issue was that the padding wasn't applied?

If it's just inconsistent, it's best to fix it in the code, so the layout would work with other screen types

@david-allison Yeah true as well, The padding wasn't applied - I changed the value multiple times and it wasn't reflecting on the UI

Could you fix the comment, future devs would be confused if it remained.

david-allison · 2026-03-22T19:52:44Z

    <string name="model_field_editor_reposition_menu">Reposition field</string>
    <string name="model_field_editor_changing">Updating fields</string>
    <string name="model_field_editor_sort_field">Sort by this field</string>
+    <string name="model_editor_name">Name</string>


Chaos10001 · 2026-03-24T00:05:29Z

@lukstbit fixed merge conflict

david-allison · 2026-03-24T01:40:59Z

Please rebase/squash next time, rather than adding in a merge commit. We rebase all commits to main, so want a clean history.

david-allison

Caught a potential issue while looking into this

david-allison · 2026-03-24T01:50:21Z

+                    setTitle(TR.notetypesAddNoteType())
+                    customView(binding.root)
+                    positiveButton(R.string.menu_add) { _ ->
+                        val newName = binding.notetypeNewName.text.toString()


This no longer trims the input, why?

Please add a @NeedsTest annotation to the method if this was a bug

Oh, that didn't come from my end though — it came from the merge conflict, I had to make a balance between the merged code and my code or else I did continue getting a merge conflict

But you reverted the merged code, which was correct

I will work on it and tag you once I made a push then

Chaos10001 · 2026-03-25T07:05:20Z

@david-allison Pls review

david-allison

Cheers! Very minor fixup needed

Chaos10001 · 2026-03-26T12:53:11Z

@david-allison Pls review

david-allison

I approved previously, but the code is great, congrats!!

Can't merge it yet due to conflicts. Please modify the git history (rebase + force push) so:

Merge commits are removed
Either:
- commits are split out into rebaseable changes
- there is 1 squashed commit
commits have a good title and description

Changes: - improve dialog appearance by using a Material 3 outlined input box - displays a visual error when a name that already exists is entered by the user - implements a sentence case for TR.notetypesAddNoteType() backend string

lukstbit

Thanks for contributing!

To get this in I pushed to:

fix conflicts
create a single commit
fix some of the issues I noticed when reviewing

How the dialog looks now:

github-actions · 2026-03-26T19:54:44Z

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

Chaos10001 · 2026-03-26T20:04:35Z

@david-allison Thank you for the constant reviews and patiently pointing out mistakes i made - it was really rewarding and i gained alot from this little interaction between us

@lukstbit Thanks for the review and final merge - I will check the issues you fixed

Its really great working with you both, Hoping to contribute more to ankidroid, Cheers🥂

david-allison · 2026-03-26T20:08:47Z

CONGRATS!!!

github-actions Bot added Strings New contributor Needs Review labels Mar 18, 2026

david-allison reviewed Mar 19, 2026

View reviewed changes

Comment thread AnkiDroid/src/main/res/values/17-model-manager.xml Outdated

qingfeng19491001 mentioned this pull request Mar 20, 2026

Fix #20466 improve Add note type dialog #20479

Closed

4 tasks

This was referenced Mar 20, 2026

Fix/card type dialogs #20473

Closed

Improve "Rename note type" dialog #20499

Merged

david-allison requested changes Mar 20, 2026

View reviewed changes

david-allison reviewed Mar 21, 2026

View reviewed changes

Comment thread AnkiDroid/src/test/java/com/ichi2/anki/ui/internationalization/SentenceCaseTest.kt Outdated

david-allison reviewed Mar 22, 2026

View reviewed changes

Comment thread AnkiDroid/src/main/res/values/sentence-case.xml Outdated

Comment thread AnkiDroid/src/main/res/values/03-dialogs.xml

Comment thread AnkiDroid/src/main/java/com/ichi2/anki/notetype/AddNewNotesType.kt Outdated

david-allison reviewed Mar 22, 2026

View reviewed changes

Comment thread AnkiDroid/src/main/java/com/ichi2/anki/notetype/AddNewNotesType.kt Outdated

david-allison reviewed Mar 22, 2026

View reviewed changes

david-allison approved these changes Mar 22, 2026

View reviewed changes

david-allison added Needs Second Approval Has one approval, one more approval to merge squash-merge A squash & force push is required. The PR author may do this to speed up the merge process. and removed Needs Review labels Mar 22, 2026

github-actions Bot added the Has Conflicts label Mar 23, 2026

github-actions Bot removed the Has Conflicts label Mar 24, 2026

david-allison requested changes Mar 24, 2026

View reviewed changes

lukstbit added the Needs Author Reply Waiting for a reply from the original author label Mar 24, 2026

lukstbit changed the title ~~ui: enhance Add Note Type dialog styling and validation~~ Enhance Add Note Type dialog styling and validation Mar 24, 2026

Chaos10001 requested a review from david-allison March 25, 2026 19:56

david-allison removed Needs Author Reply Waiting for a reply from the original author Needs Second Approval Has one approval, one more approval to merge labels Mar 25, 2026

david-allison approved these changes Mar 26, 2026

View reviewed changes

Comment thread AnkiDroid/src/main/res/layout/dialog_new_note_type.xml Outdated

Comment thread AnkiDroid/src/main/res/layout/dialog_new_note_type.xml Outdated

david-allison added the Needs Second Approval Has one approval, one more approval to merge label Mar 26, 2026

david-allison approved these changes Mar 26, 2026

View reviewed changes

lukstbit force-pushed the chaos branch from 8505efe to bfa58f7 Compare March 26, 2026 19:08

lukstbit force-pushed the chaos branch from bfa58f7 to b83c9b1 Compare March 26, 2026 19:18

lukstbit approved these changes Mar 26, 2026

View reviewed changes

lukstbit enabled auto-merge March 26, 2026 19:22

lukstbit added this pull request to the merge queue Mar 26, 2026

Merged via the queue into ankidroid:main with commit 4e2bd4a Mar 26, 2026
15 checks passed

github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Mar 26, 2026

github-actions Bot added this to the 2.24 release milestone Mar 26, 2026

lukstbit mentioned this pull request Mar 26, 2026

Updated strings from Crowdin 2026/03/26 19:56 #20604

Merged

		// Previously used inconsistent padding (32/64dp) that didn't follow the spec.
		// See: https://m3.material.io/components/dialogs/specs

Uh oh!

Conversation

Chaos10001 commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose / Description

Fixes

Approach

How Has This Been Tested?

Uh oh!

github-actions Bot commented Mar 18, 2026

Uh oh!

ZornHadNoChoice commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

david-allison commented Mar 20, 2026

Uh oh!

Chaos10001 commented Mar 20, 2026

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

david-allison Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

david-allison Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Chaos10001 commented Mar 22, 2026

Uh oh!

Uh oh!

david-allison commented Mar 22, 2026

Uh oh!

david-allison Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Chaos10001 Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

david-allison Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chaos10001 Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

david-allison Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chaos10001 commented Mar 24, 2026

Uh oh!

david-allison commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

david-allison left a comment

Choose a reason for hiding this comment

Uh oh!

david-allison Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Chaos10001 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

david-allison Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chaos10001 commented Mar 18, 2026 •

edited

Loading

ZornHadNoChoice commented Mar 19, 2026 •

edited

Loading

david-allison Mar 22, 2026 •

edited

Loading

david-allison Mar 22, 2026 •

edited

Loading

david-allison Mar 22, 2026 •

edited

Loading

david-allison commented Mar 24, 2026 •

edited

Loading

david-allison Mar 24, 2026 •

edited

Loading

david-allison left a comment •

edited

Loading