Test: Remember value used when increasing reviews

[manocormen]

Purpose / Description

When you start a custom study session and increase your "review limit" by a certain value, that value is remembered and becomes the default for your next review limit increase. This PR adds a test to preserve that behavior.

Fixes

• Related to [Cleanup]: Add Tests to the code (@NeedsTest) #13283.

Approach

There was already a test for a very similar behavior: remembering "new cards limit" increases. That test is relatively recent, so I used it as reference for the new test, simply adapting it to check the "review limit" instead of "new cards limit". I placed the new test right underneath its "sibling".

How Has This Been Tested?

./gradlew jacocoUnitTestReport
./gradlew lintRelease
./gradlew ktlintCheck

Learning

Lesson learned:

• @NeedsTest may also be found in existing test files; so far, I'd only searched for them in prod files.
• Consider the performance cost of your tests.
• Prefer properties over raw JSON access when possible.

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings) NA
• UI Changes: You have tested your change using the Google Accessibility Scanner NA

[david-allison]

One query on performance, then let's get this in

[david-allison]

BEAUTIFUL

One recommendation

https://github.com/ankidroid/Anki-Android/wiki/Development-Guide/#applying-a-patch

Subject: [PATCH]
---
Index: AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt b/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt
--- a/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt	(revision d1bfd3dfc23dc1020c8dd57706613551ebdb4026)
+++ b/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/CustomStudyDialogTest.kt	(date 1774149516036)
@@ -164,9 +164,7 @@
     @Test
     fun `previous value for 'increase review card limit' is suggested`() {
         // Reduce review limit to 0, so we can successfully extend with just 1 review card.
-        updateDeckConfig(Consts.DEFAULT_DECK_ID) {
-            rev.jsonObject.put("perDay", 0)
-        }
+        updateDeckConfig(Consts.DEFAULT_DECK_ID) { rev.perDay = 0 }
         addRevBasicNoteDueToday("Review", "Today")
 
         val reviewExtendByValue = 1
Index: libanki/src/main/java/com/ichi2/anki/libanki/DeckConfig.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/libanki/src/main/java/com/ichi2/anki/libanki/DeckConfig.kt b/libanki/src/main/java/com/ichi2/anki/libanki/DeckConfig.kt
--- a/libanki/src/main/java/com/ichi2/anki/libanki/DeckConfig.kt	(revision d1bfd3dfc23dc1020c8dd57706613551ebdb4026)
+++ b/libanki/src/main/java/com/ichi2/anki/libanki/DeckConfig.kt	(date 1774149530767)
@@ -128,6 +128,9 @@
     data class Rev(
         override val jsonObject: JSONObject,
     ) : JSONObjectHolder {
+        @VisibleForTesting
+        var perDay by jsonInt("perDay")
+
         @VisibleForTesting
         var delays by jsonArray("delays")
 

[manocormen]

Thanks. That's very clean. I've applied the patch and updated the PR.

[david-allison]

Very clean indeed, cheers!