fix(tui): avoid opentui-spinner color type conflicts#26116
Open
gmnstr wants to merge 1 commit intoanomalyco:devfrom
Open
fix(tui): avoid opentui-spinner color type conflicts#26116gmnstr wants to merge 1 commit intoanomalyco:devfrom
gmnstr wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #26119
Type of change
What does this PR do?
This fixes a package typecheck failure in
packages/opencode/src/cli/cmd/tui/ui/spinner.tscaused by importingColorGeneratorthroughopentui-spinner.The problem is that the repo uses
@opentui/core@0.2.2, whileopentui-spinner@0.0.6is typed against@opentui/core@^0.1.49. That causes Bun to install two different@opentui/coretype graphs, and the brandedColorInput/RGBAtypes stop matching.This PR replaces the imported
ColorGeneratortype with an equivalent local structural alias inspinner.ts.Why this works:
@opentui/coretypes throughopentui-spinnerbun typechecksucceeds again inpackages/opencodeHow did you verify your code works?
From
packages/opencode:bun typecheckScreenshots / recordings
N/A — no UI changes.
Checklist