fix(windows): detach child process to prevent taskkill /F /IM node.exe from killing opencode#26127
Open
Sanjay-doppalapudi wants to merge 2 commits intoanomalyco:devfrom
Open
Conversation
…lling opencode on Windows
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Related PR Found:
|
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #25930
Type of change
What does this PR do?
On Windows, when OpenCode is installed via npm, the
bin/opencodelauncher is a Node.js script that useschildProcess.spawnSync()to run the compiledopencode.exebinary. BecausespawnSyncis synchronous, thenode.exeprocess stays alive as a blocking parent ofopencode.exefor the entire session. Runningtaskkill /F /IM node.exe(or similar) kills the node launcher, which also brings downopencode.exe.This fixes it by switching from
spawnSynctospawnwithdetached: trueand explicit stdio handles ([0, 1, 2]). The child process now runs in its own process group, so force-killingnode.exeno longer cascades toopencode.exe.Note: PR #25762 addresses a related but different aspect — it adds prompt/runtime guards to prevent the AI from issuing these commands. This PR fixes the underlying process architecture so that even if the commands are run (by the user manually, or any other scenario), OpenCode survives.
How did you verify your code works?
node --checkconfirms the launcher script is syntactically validbun run devlaunches OpenCode correctly — TUI renders, console output workstaskkill /F /IM node.exein a separate terminalScreenshots / recordings
N/A — no UI changes.
Checklist