fix(nix): build desktop package with electron#26140
Open
tommoa wants to merge 1 commit intoanomalyco:devfrom
Open
fix(nix): build desktop package with electron#26140tommoa wants to merge 1 commit intoanomalyco:devfrom
tommoa wants to merge 1 commit intoanomalyco:devfrom
Conversation
The desktop package no longer has the Tauri src-tauri tree, so the Nix desktop derivation packages the Electron app instead of using cargo-tauri. The Electron renderer and main outputs are built with the shared node_modules derivation, and the unpacked app uses Nix-provided Electron to avoid sandbox downloads. Electron auto-updates are disabled for Nix builds, the derivation version is preserved in Electron metadata, the app runtime has ripgrep on PATH, and the unpacked Linux app includes desktop integration. Fixes anomalyco#26120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop package no longer has the Tauri
src-tauritree, so the Nix desktop derivation packages the Electron app instead of usingcargo-tauri. The Electron renderer and main outputs are built with the sharednode_modulesderivation, and the unpacked app uses Nix-provided Electron to avoid sandbox downloads.Issue for this PR
Closes #26120
Type of change
What does this PR do?
This PR modifies the desktop flake to use the new electron build process for the desktop app. There were some things that needed to be modified to have parity with the old flake:
nixdoes not allow writable locations, so the auto-updater needed to be disabledelectron-builderdoesn't generate a.desktopfor Linux, so a.desktopis made in the flakeHow did you verify your code works?
nix run .#desktopon macOS 26.4.1, which worked.Checklist