Skip to content

Dans le converter, créer une méthodes pour récupérer la donnée dans le sens 15-18#384

Merged
bou3108 merged 6 commits intoconverter/rc-ri-single-messagefrom
feat/converter/add-rs-sr-fetching-method
Mar 24, 2026
Merged

Dans le converter, créer une méthodes pour récupérer la donnée dans le sens 15-18#384
bou3108 merged 6 commits intoconverter/rc-ri-single-messagefrom
feat/converter/add-rs-sr-fetching-method

Conversation

@bou3108
Copy link
Copy Markdown
Collaborator

@bou3108 bou3108 commented Mar 19, 2026

🔎 Détails

Dans le sens 15-18, le converter a besoin d'accéder aux messages RS-RI et RS-SR pour pouvoir reconstruire un RC-RI. Cette PR implémente la couche d'accès aux données.

  • Ajout des méthodes get_last_rs_ri_by_case_id et get_last_rs_sr_by_case_id pour récupérer les derniers messages RS-RI et RS-SR pour un case_id donné
  • la méthode get_last_rs_sr_by_case_id s'appuie sur un pipeline mongo pour récupérer tous les rs_sr correspondant au case_id, les ordonner, les grouper par ressource et ne récupérer que le plus récent
  • Refacto de la méthode _make_doc pour la partager entre les tests des différents types de message
  • Renommage de variables pour oplus de clarté
  • Ajout des TUs relatifs aux méthodes implémentées

🔗 Ticket associé

14. Dans le converter, créer une méthodes pour récupérer la donnée dans le sens 15-18

@bou3108 bou3108 changed the base branch from main to converter/rc-ri-single-message March 19, 2026 12:26
@github-actions
Copy link
Copy Markdown

There is no coverage information present for the Files changed

Total Project Coverage 52.5% 🍏

@bou3108 bou3108 changed the title Feat/converter/add rs sr fetching method Dans le converter, créer une méthodes pour récupérer la donnée dans le sens 15-18 Mar 19, 2026
@github-actions
Copy link
Copy Markdown

There is no coverage information present for the Files changed

Total Project Coverage 52.4% 🍏

2 similar comments
@github-actions
Copy link
Copy Markdown

There is no coverage information present for the Files changed

Total Project Coverage 52.4% 🍏

@github-actions
Copy link
Copy Markdown

There is no coverage information present for the Files changed

Total Project Coverage 52.4% 🍏

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 19, 2026

Coverage

Converter - python code coverage
FileStmtsMissCoverMissing
constants.py40100% 
conversion_mixin.py23195%24
converter.py67395%26, 94–95
database.py322231%12, 16, 18–21, 23, 25, 27, 29–38, 40–41, 49
logging_config.py35294%29, 36
utils.py164398%57, 108, 120
cisu
   base_cisu_converter.py33390%7, 25, 31
   constants.py40100% 
   identical_cisu_converter.py90100% 
   utils.py150100% 
cisu/create_case
   create_case_cisu_constants.py310100% 
   create_case_cisu_converter.py145199%112
cisu/reference
   reference_converter.py9277%9, 13
cisu/resources_info
   resources_info_cisu_constants.py110100% 
   resources_info_cisu_converter.py146199%154
cisu/resources_status
   resources_status_converter.py8275%7, 11
conversion_strategy
   cisu_conversion_strategy.py49295%68, 93
   conversion_strategy.py70100% 
   health_conversion_strategy.py460100% 
models
   persisted_message.py130100% 
repositories
   message_repository.py701282%90–91, 98, 118–120, 122–123, 125, 171–173
versions
   base_message_converter.py831285%13, 72–74, 86, 98, 102, 106, 110, 114, 118, 124
   error_converter.py5180%7
   identical_message_converter.py150100% 
   utils.py26580%34–37, 43
versions/create_case_health
   constants.py40100% 
   create_case_health_converter.py1780100% 
   create_case_health_update_converter.py50100% 
versions/create_case_health/v1_v2
   constants.py170100% 
   utils.py460100% 
versions/create_case_health/v2_v3
   constants.py290100% 
versions/geo_positions_update
   geo_positions_update_constants.py40100% 
   geo_positions_update_converter.py49393%31, 42, 79
versions/geo_resources_details
   geo_resources_details_constants.py40100% 
   geo_resources_details_converter.py270100% 
versions/reference
   reference_constants.py20100% 
   reference_converter.py130100% 
versions/resources_engagement
   resources_engagement_constants.py30100% 
   resources_engagement_converter.py220100% 
versions/resources_info
   resources_info_constants.py200100% 
   resources_info_converter.py870100% 
versions/resources_request
   resources_request_constants.py20100% 
   resources_request_converter.py210100% 
versions/resources_response
   resources_response_constants.py40100% 
   resources_response_converter.py160100% 
versions/resources_status
   resources_status_constants.py100100% 
   resources_status_converter.py390100% 
TOTAL16527595% 

@bou3108 bou3108 marked this pull request as ready for review March 19, 2026 12:51
@bou3108 bou3108 force-pushed the feat/converter/add-rs-sr-fetching-method branch from d867add to 409770d Compare March 19, 2026 12:54
@github-actions
Copy link
Copy Markdown

There is no coverage information present for the Files changed

Total Project Coverage 52.4% 🍏

Comment thread converter/converter/repositories/message_repository.py Outdated
Comment thread converter/tests/repositories/test_message_repository.py Outdated
Comment thread converter/tests/repositories/test_message_repository.py Outdated
Comment thread converter/tests/repositories/test_message_repository.py Outdated
Comment thread converter/tests/repositories/test_message_repository.py Outdated
Comment thread converter/converter/repositories/message_repository.py Outdated
{"$sort": {"arrivedAt": -1}},
{
"$group": {
"_id": f"${_RS_SR_RESOURCE_ID_PATH}",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi on utilise une fstring ici et pas dans les autres cas plus haut ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus haut, on passe directement la constante car on référence "field".

Dans le cadre de la directive "group", on a besoin de référencer "$field" et non "field", donc on doit ajouter le $ devant la constante _RS_SR_RESOURCE_ID_PATH

Comment thread converter/tests/repositories/test_message_repository.py Outdated
@github-actions
Copy link
Copy Markdown

There is no coverage information present for the Files changed

Total Project Coverage 52.4% 🍏

@github-actions
Copy link
Copy Markdown

There is no coverage information present for the Files changed

Total Project Coverage 52.4% 🍏

@bou3108 bou3108 merged commit 1278cf1 into converter/rc-ri-single-message Mar 24, 2026
2 checks passed
@bou3108 bou3108 deleted the feat/converter/add-rs-sr-fetching-method branch March 24, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants