Modified Endpoints for multiple managers and new compaction summary#6251
Open
dlmarion wants to merge 1 commit intoapache:mainfrom
Open
Modified Endpoints for multiple managers and new compaction summary#6251dlmarion wants to merge 1 commit intoapache:mainfrom
dlmarion wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
@DomGarguilo - this changes two endpoints. Let me know if you want any changes in the response object formats and I can make them. |
Member
I think with these changes the JSON will be something like: {
"type=MANAGER;group=default;address=localhost:9995": [
{ "...": "metric..." },
{ "...": "metric..." }
]
}That will work but is not quite as nice to parse. I'm thinking it might be better to send a list of objects instead of a map. so something like this: [
{
"server": {
"type": "MANAGER",
"resourceGroup": "default",
"address": "localhost:9995"
},
"metrics": [
{ "...": "metric..." },
{ "...": "metric..." }
]
}
]Not exactly sure what the code will look like but could create something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6247