Removes hadoop.fs.Path from RecoveryPath#6262
Open
ddanielr wants to merge 1 commit intoapache:mainfrom
Open
Conversation
Removes the need to create various path objects to use RecoveryPath Processes the Path object without multiple getParent calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most uses of RecoveryPath were using
toString()on the returned object or usingnew Path()on an existing string to create the new recoveryPath.This PR removes the need to create various path objects to use RecoveryPath.
It also completely removes the use of hadoop.fs.Path in RecoveryPath and handles the path validation via string manipulation.
This allows the walPath to be processed without multiple getParent calls.
The old method was moved into the test code for behavior validation.