feat(csharp): add PII redaction in tracing, by default#4027
feat(csharp): add PII redaction in tracing, by default#4027birschick-bq wants to merge 9 commits intoapache:mainfrom
Conversation
…text for trace activity
|
@CurtHagenlocher - let me know if you have some time to review this or if is a low priority for you. Thanks. |
|
I think we can remove the changes that are under the Drivers folder since those are on the deprecation path. The changes are only needed in the new Foundry repo. |
I see. You mention in the description the build was breaking without that. |
I could remove the |
|
Yes lets do that. |
Adds PII redaction in tracing, by default.
The new class
ActivityWithPiiwraps theSystem.Diagnostics.Activityobject and replicates its interface. By default, the methods assume that tag values passed to the methods contain PII, unless explicitly marked otherwise (i.e.,isPii = false).The previous
TraceActivityoverloads and extension method that are useActivityhave been marked asObsolete. They have been replaced with overloads using the newActivityWithPiiclass.As marking the
TraceActivityoverloads and extension methods asObsoletecauses the build to fail, I've update the drivers in two commits. The first commit uses#pragmato ignore the warnings. The second commit, implements the change to use the newActivityWithPiiclass.The
FileExporterandFileListenerhave been updated to reveal the original that have been redacted - with the assumption that writing to the local file system is controlled by an authorized user.