test: add overflow tests for MutableBuffer#9958
Open
SoimanVasile wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While analyzing the memory allocation logic in
MutableBuffer, I identified that thewith_capacityandreservemethods correctly use.expect()guards to prevent integer overflows.However, I couldnt find test cases for this
.expect()guard in the current test suite. This PR adds 2#[should_panic]tests inmutable.rsto verify that the API correctly panicsChanges:
test_mutable_new_capacity_overflowto coverMutableBuffer::newtest_mutable_reserve_overflowto coverMutableBuffer::reserveRationale
Adding these tests ensures that the safety guards in
arrow-bufferremain intact and provides explicit coverage for edge cases involving near-usize::MAXallocations.Tests
test_mutable_new_capacity_overflowtest_mutable_reserve_overflow