[CALCITE-7447] RelRoot.project() adds Project for DDL nodes#4841
Open
nielspardon wants to merge 1 commit intoapache:mainfrom
Open
[CALCITE-7447] RelRoot.project() adds Project for DDL nodes#4841nielspardon wants to merge 1 commit intoapache:mainfrom
nielspardon wants to merge 1 commit intoapache:mainfrom
Conversation
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
|
mihaibudiu
approved these changes
Mar 20, 2026
xiedeyantu
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7447
Changes Proposed
While Calcite does not officially have DDL RelNodes we are extending Calcite in substrait-java to be able to work with DDL operations as RelNodes.
When we then use the
RelRoot.project(true)function to access theRelRoot.relthese DDL operations are currently getting wrapped in aLogicalProjectwhich obviously does not make sense.Since the code in
RelRoot.project()already checks whether theRelRoot.kindis a DML operation we can simply also check whether it is a DDL operation to avoid falsely wrapping those operations in aLogicalProject.