[CELEBORN-2320] Grafana dashboard linter should build from a checkout instead#3679
Closed
SteNicholas wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-2320] Grafana dashboard linter should build from a checkout instead#3679SteNicholas wants to merge 1 commit intoapache:mainfrom
SteNicholas wants to merge 1 commit intoapache:mainfrom
Conversation
8c22d9c to
790d7d0
Compare
RexXiong
approved these changes
May 8, 2026
Member
Author
|
Merged to main(v0.7.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Grafana dashboard linter should build from a checkout instead.
Backport grafana/dashboard-linter#252.
Why are the changes needed?
This PR introduces GoReleaser to help create GitHub releases and compiled binaries.
The new release workflow will trigger on git tags starting with v.
In particular, providing pre-built release binaries addresses the following problem currently seen in main:
go install github.com/grafana/dashboard-linter@<version>does not currently work becausego.modcontains areplacedirective — Go refuses to install a module with replaces. Build from a checkout instead:Does this PR resolve a correctness bug?
No.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Grafana Dashboard CI / lint (pull_request).