Skip to content

[CELEBORN-2320] Grafana dashboard linter should build from a checkout instead#3679

Closed
SteNicholas wants to merge 1 commit intoapache:mainfrom
SteNicholas:CELEBORN-2320
Closed

[CELEBORN-2320] Grafana dashboard linter should build from a checkout instead#3679
SteNicholas wants to merge 1 commit intoapache:mainfrom
SteNicholas:CELEBORN-2320

Conversation

@SteNicholas
Copy link
Copy Markdown
Member

@SteNicholas SteNicholas commented May 8, 2026

What changes were proposed in this pull request?

Grafana dashboard linter should build from a checkout instead.

Backport grafana/dashboard-linter#252.

Why are the changes needed?

This PR introduces GoReleaser to help create GitHub releases and compiled binaries.

The new release workflow will trigger on git tags starting with v.

In particular, providing pre-built release binaries addresses the following problem currently seen in main:

go: downloading github.com/grafana/dashboard-linter v0.1.0
go: github.com/grafana/dashboard-linter@latest (in github.com/grafana/dashboard-linter@v0.1.0):
	The go.mod file for the module providing named packages contains one or
	more replace directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.

go install github.com/grafana/dashboard-linter@<version> does not currently work because go.mod contains a replace directive — Go refuses to install a module with replaces. Build from a checkout instead:

$ git clone https://github.com/grafana/dashboard-linter.git
$ cd dashboard-linter
$ go build -o dashboard-linter .
$ ./dashboard-linter lint dashboard.json

Does this PR resolve a correctness bug?

No.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Grafana Dashboard CI / lint (pull_request).

@SteNicholas SteNicholas force-pushed the CELEBORN-2320 branch 2 times, most recently from 8c22d9c to 790d7d0 Compare May 8, 2026 07:34
@SteNicholas
Copy link
Copy Markdown
Member Author

Merged to main(v0.7.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants