Skip to content

systemvm: fix VPC VPN issue when network id is bigger than 1000 on Netris#13346

Open
weizhouapache wants to merge 1 commit into
apache:4.22from
weizhouapache:4.22-netris-fix-vpc-vpn
Open

systemvm: fix VPC VPN issue when network id is bigger than 1000 on Netris#13346
weizhouapache wants to merge 1 commit into
apache:4.22from
weizhouapache:4.22-netris-fix-vpc-vpn

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

Description

This PR fixes the issue that when network id is bigger than 1000 on Netris, the VPN is not setup.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache changed the base branch from main to 4.22 June 4, 2026 06:32
@weizhouapache weizhouapache requested a review from Copilot June 4, 2026 06:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@weizhouapache weizhouapache requested a review from Copilot June 4, 2026 06:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.10%. Comparing base (21b2025) to head (8a065c1).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #13346      +/-   ##
============================================
+ Coverage     17.67%   18.10%   +0.43%     
- Complexity    15792    16751     +959     
============================================
  Files          5922     6037     +115     
  Lines        533165   542798    +9633     
  Branches      65208    66457    +1249     
============================================
+ Hits          94242    98281    +4039     
- Misses       428276   433470    +5194     
- Partials      10647    11047     +400     
Flag Coverage Δ
uitests 3.51% <ø> (-0.18%) ⬇️
unittests 19.27% <ø> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache requested a review from Copilot June 4, 2026 06:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@weizhouapache weizhouapache marked this pull request as ready for review June 4, 2026 06:48
@weizhouapache weizhouapache added this to the 4.22.2 milestone Jun 4, 2026
@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18147

Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@nvazquez nvazquez requested a review from Pearl1594 June 4, 2026 11:03
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants