kvm/security_group: Make Security Group Python 3 compatible#3589
Conversation
This script only runs on the KVM Hypervisors and these all support Python 3. As Python 2 is deprecated at the end of 2019 we need to fix these scripts to work under Python 3. CentOS 7, 8 and Ubuntu 16.04 and 18.04 all have Python 3 installed by default. Ubuntu 20.04 will no longer have Python 2 installed and therefor this script needs to be modified to work with Python 3. Signed-off-by: Wido den Hollander <wido@widodh.nl>
wido
added
component:kvm
component:security-group
Python
GabrielBrascher
left a comment
GabrielBrascher
left a comment
There was a problem hiding this comment.
Tested and security group rules are applied as expected. LGTM based on code review and tests.
|
@wido @GabrielBrascher can you add dependency of |
yadvr
left a comment
yadvr
left a comment
There was a problem hiding this comment.
With el6 deprecated, this can be accepted now with ensuring that python3 is installed with cloudstack-common or cloudstack-agent packages.
|
@rhtyd updated adding the dependency of python3 in packaging/centos7/cloud.spec. Thanks! |
|
|
||
| Package: cloudstack-common | ||
| Architecture: all | ||
| Depends: ${misc:Depends}, ${python:Depends}, genisoimage, nfs-common, python-netaddr |
There was a problem hiding this comment.
@wido @GabrielBrascher Do we no longer need python-netaddr? (for all/any py scripts?)
| Summary: CloudStack management server UI | ||
| Requires: java-1.8.0-openjdk | ||
| Requires: python | ||
| Requires: python3 |
There was a problem hiding this comment.
We probably want both python and python3 like the debian/control change @GabrielBrascher, please add a new Requires line
There was a problem hiding this comment.
@rhtyd ah sure. Updated it, thanks!
|
Thanks @GabrielBrascher left some minor remarks |
GabrielBrascher
force-pushed
the
security-group-py3
branch
from
a8be89a to
07213a9
Compare
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-285 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-376)
|
) * kvm/security_group: Make Security Group Python 3 compatible This script only runs on the KVM Hypervisors and these all support Python 3. As Python 2 is deprecated at the end of 2019 we need to fix these scripts to work under Python 3. CentOS 7, 8 and Ubuntu 16.04 and 18.04 all have Python 3 installed by default. Ubuntu 20.04 will no longer have Python 2 installed and therefor this script needs to be modified to work with Python 3. Signed-off-by: Wido den Hollander <wido@widodh.nl> * Add dependency of python3 in packaging/centos7/cloud.spec
4 participants
This script only runs on the KVM Hypervisors and these all support
Python 3.
As Python 2 is deprecated at the end of 2019 we need to fix these
scripts to work under Python 3.
CentOS 7, 8 and Ubuntu 16.04 and 18.04 all have Python 3 installed
by default.
Ubuntu 20.04 will no longer have Python 2 installed and therefor
this script needs to be modified to work with Python 3.
Signed-off-by: Wido den Hollander wido@widodh.nl