kvm: Logrotate should not touch agent.log#3597
Merged
Merged
Conversation
Logrotate should only touch security_group.log and resizevolume.log as the agent.log is already rotated by log4j inside the Agent. Having two systems trying to rotate agent.log leads to all kinds of issues like having binary (compressed) data in the middle of a plain-text log file. In addition we do not have to rotate the logs every day, only when they grow larger than 10M. On fairly idle hypervisors this should not cause those logs to rotate every day. Signed-off-by: Wido den Hollander <wido@widodh.nl>
yadvr
approved these changes
Sep 18, 2019
Member
|
(el6 failure expected) |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-282 |
Member
|
Config and packaging only change, wont' need smoketests. |
Contributor
|
Isn't the commit message a bit misleading? |
Contributor
|
@onitake no, resizevolume.log is new in logrotate |
Contributor
|
Ah, ok. |
Contributor
|
@rhtyd can you cherry-pick this commit to 4.13 branch ? |
DaanHoogland
pushed a commit
that referenced
this pull request
Jan 3, 2020
Logrotate should only touch security_group.log and resizevolume.log as the agent.log is already rotated by log4j inside the Agent. Having two systems trying to rotate agent.log leads to all kinds of issues like having binary (compressed) data in the middle of a plain-text log file. In addition we do not have to rotate the logs every day, only when they grow larger than 10M. On fairly idle hypervisors this should not cause those logs to rotate every day. Signed-off-by: Wido den Hollander <wido@widodh.nl>
ustcweizhou
pushed a commit
to ustcweizhou/cloudstack
that referenced
this pull request
Feb 28, 2020
Logrotate should only touch security_group.log and resizevolume.log as the agent.log is already rotated by log4j inside the Agent. Having two systems trying to rotate agent.log leads to all kinds of issues like having binary (compressed) data in the middle of a plain-text log file. In addition we do not have to rotate the logs every day, only when they grow larger than 10M. On fairly idle hypervisors this should not cause those logs to rotate every day. Signed-off-by: Wido den Hollander <wido@widodh.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logrotate should only touch security_group.log and resizevolume.log
as the agent.log is already rotated by log4j inside the Agent.
Having two systems trying to rotate agent.log leads to all kinds of
issues like having binary (compressed) data in the middle of a plain-text
log file.
Signed-off-by: Wido den Hollander wido@widodh.nl