vrouter: remove a POSTROUTING rule for port forwarding in VPC router by ustcweizhou · Pull Request #3952 · apache/cloudstack

ustcweizhou · 2020-03-09T14:43:00Z

Description

As discussed in #3937 (comment)
a rule for port forwarding in VPC router might not be needed.

This fixes the failed result of health check for network VRs.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2020-03-09T14:43:52Z

@DaanHoogland can you kick off test for this PR ?

DaanHoogland · 2020-03-10T11:55:18Z

@blueorangutan package

blueorangutan · 2020-03-10T11:55:30Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-03-10T12:21:19Z

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1038

DaanHoogland · 2020-03-10T23:54:08Z

@blueorangutan test

blueorangutan · 2020-03-10T23:54:33Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-03-11T13:36:33Z

Trillian test result (tid-1227)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47773 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3952-t1227-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_05_rvpc_multi_tiers	`Failure`	490.68	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	518.61	test_vpc_redundant.py

andrijapanicsb · 2020-03-12T10:54:34Z

Testing this one, instead of #3937 - we removed the offending rule, so additional code to handle VPC vs Isolated network VR is not needed.

andrijapanicsb · 2020-03-12T11:53:38Z

@weizhouapache testing this one - and after configuring port forward (and stopping iptables on the guest VM) - I can't connect via PF rule to the VM (works fine for VPC though).

Can you please take a look? Otherwise, since we are 1 day from the freeze for 4.14., I'll have to go with #3937 (but I prefer your PR with removed extra lines) ?

weizhouapache · 2020-03-12T14:18:29Z

@weizhouapache testing this one - and after configuring port forward (and stopping iptables on the guest VM) - I can't connect via PF rule to the VM (works fine for VPC though).

Can you please take a look? Otherwise, since we are 1 day from the freeze for 4.14., I'll have to go with #3937 (but I prefer your PR with removed extra lines) ?

@andrijapanicsb I will look into it today.
one suggestion, can we easily remove a line in systemvm/debian/root/health_checks/iptables_check.py as a workaround ? health check will pass in both network and vpc vr.

https://github.com/apache/cloudstack/pull/3952/files#diff-cf7b342df9a0681cd60e083d7f746bd2

andrijapanicsb · 2020-03-12T14:35:18Z

I see it should work @weizhouapache , but let me ping @Pearl1594 for the opinion

thx

andrijapanicsb · 2020-03-12T15:14:50Z

We'll do another PR with just that one change, thanks @weizhouapache

andrijapanicsb · 2020-03-13T12:13:13Z

@weizhouapache the PR was made, tested (by you and @Pearl1594 - thanks ) and merged - here #3963

Do you want to close this one now or... ?
I will remove the milestone from it - thanks!

weizhouapache · 2020-03-14T07:01:45Z

@weizhouapache the PR was made, tested (by you and @Pearl1594 - thanks ) and merged - here #3963

Do you want to close this one now or... ?
I will remove the milestone from it - thanks!

considering we have merged #3963 , I think we can move this to 4.14.1

by the way, I have tested the failed test test_vpc_redundant.py in my local testing environment, no issue at all.

yadvr · 2020-06-13T00:41:30Z

@blueorangutan package

blueorangutan · 2020-06-13T00:42:11Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-13T01:43:08Z

Packaging result: ✖centos7 ✖debian. JID-1366

yadvr · 2020-07-02T09:28:01Z

@blueorangutan package

blueorangutan · 2020-07-02T09:28:47Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-07-02T10:30:23Z

Packaging result: ✔centos7 ✔debian. JID-1509

yadvr · 2020-07-02T10:46:40Z

@blueorangutan test

blueorangutan · 2020-07-02T10:48:04Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2020-07-04T05:28:40Z

@blueorangutan test

blueorangutan · 2020-07-04T05:30:29Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-07-04T19:47:23Z

Trillian test result (tid-1975)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46271 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3952-t1975-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 78 look OK, 5 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_sys_vm_start	`Failure`	0.06	test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
test_01_deploy_vm_on_specific_host	`Error`	35.91	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	6.27	test_vm_deployment_planner.py
test_11_migrate_vm	`Error`	6.30	test_vm_life_cycle.py
test_hostha_enable_ha_when_host_disconected	`Error`	936.27	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	300.74	test_hostha_kvm.py

yadvr · 2020-07-07T07:17:03Z

@ustcweizhou can you review the test failures?

weizhouapache · 2020-07-24T07:09:55Z

@ustcweizhou can you review the test failures?

@rhtyd can you re-kick off the tests ?

yadvr · 2020-07-28T08:27:41Z

@blueorangutan package

blueorangutan · 2020-07-28T08:28:17Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-07-28T08:56:01Z

Packaging result: ✔centos7 ✔debian. JID-1613

yadvr · 2020-07-29T07:30:23Z

@blueorangutan test

blueorangutan · 2020-07-29T07:32:00Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-07-29T17:24:35Z

Trillian test result (tid-2223)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33746 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3952-t2223-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Test File
ContextSuite context=Test01DeployVM>:setup	`Error`	test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup	`Error`	test_vm_life_cycle.py
ContextSuite context=Test03SecuredVmMigration>:setup	`Error`	test_vm_life_cycle.py

yadvr · 2020-07-30T05:22:57Z

Test LGTM the failure is due to a regression in Trillian/ansible overiding file (the test_vm_life_cycle.py and has been fixed).

yadvr

LGTM did not test is manually

DaanHoogland

code looks good and appears to do what it says on the tin.
@andrijapanicsb @Pearl1594 can one of you have a look at testing?

yadvr · 2020-08-04T05:54:14Z

The regression has been fixed, failures not related to this PR.

vrouter: remove a POSTROUTING rule for port forwarding in VPC router

8012f53

svenvogel added component:virtual-router component:vpc type:bug labels Mar 9, 2020

DaanHoogland reviewed Mar 10, 2020

View reviewed changes

Comment thread systemvm/debian/opt/cloud/bin/configure.py

vroute: not add fw_postrout_rule

b04ef6e

apache deleted a comment from blueorangutan Mar 10, 2020

andrijapanicsb mentioned this pull request Mar 13, 2020

VR Port Forward rule check on Non-VPC Isolated networks #3937

Closed

5 tasks

yadvr changed the base branch from master to 4.14 June 13, 2020 00:41

yadvr closed this Jul 2, 2020

yadvr reopened this Jul 2, 2020

yadvr requested a review from DaanHoogland July 30, 2020 05:23

yadvr approved these changes Jul 30, 2020

View reviewed changes

DaanHoogland approved these changes Jul 30, 2020

View reviewed changes

yadvr added this to the 4.14.1.0 milestone Aug 4, 2020

yadvr merged commit 407e34d into apache:4.14 Aug 4, 2020

DaanHoogland added the Severity:Minor label Nov 10, 2020

Conversation

ustcweizhou commented Mar 9, 2020

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Mar 9, 2020

Uh oh!

Uh oh!

DaanHoogland commented Mar 10, 2020

Uh oh!

blueorangutan commented Mar 10, 2020

Uh oh!

blueorangutan commented Mar 10, 2020

Uh oh!

DaanHoogland commented Mar 10, 2020

Uh oh!

blueorangutan commented Mar 10, 2020

Uh oh!

blueorangutan commented Mar 11, 2020

Uh oh!

andrijapanicsb commented Mar 12, 2020

Uh oh!

andrijapanicsb commented Mar 12, 2020

Uh oh!

weizhouapache commented Mar 12, 2020

Uh oh!

andrijapanicsb commented Mar 12, 2020

Uh oh!

andrijapanicsb commented Mar 12, 2020

Uh oh!

andrijapanicsb commented Mar 13, 2020

Uh oh!

weizhouapache commented Mar 14, 2020

Uh oh!

yadvr commented Jun 13, 2020

Uh oh!

blueorangutan commented Jun 13, 2020

Uh oh!

blueorangutan commented Jun 13, 2020

Uh oh!

yadvr commented Jul 2, 2020

Uh oh!

blueorangutan commented Jul 2, 2020

Uh oh!

blueorangutan commented Jul 2, 2020

Uh oh!

yadvr commented Jul 2, 2020

Uh oh!

blueorangutan commented Jul 2, 2020

Uh oh!

yadvr commented Jul 4, 2020

Uh oh!

blueorangutan commented Jul 4, 2020

Uh oh!

blueorangutan commented Jul 4, 2020

Uh oh!

yadvr commented Jul 7, 2020

Uh oh!

weizhouapache commented Jul 24, 2020

Uh oh!

yadvr commented Jul 28, 2020

Uh oh!

blueorangutan commented Jul 28, 2020

Uh oh!

blueorangutan commented Jul 28, 2020

Uh oh!

yadvr commented Jul 29, 2020

Uh oh!

blueorangutan commented Jul 29, 2020

Uh oh!

blueorangutan commented Jul 29, 2020

Uh oh!

yadvr commented Jul 30, 2020

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment