Update schema-41310to41400.sql

[andrijapanicsb]

Keeping the snapshot on Primary storage only, was originally implemented for KVM+Ceph specifically as it seems, since it's seriously broken for KVM+NFS/local in 4.11+ (and not applicable/doesn't affects VMware at all, while it accidentally works for XS+NFS as they share the same "strategy")

Thus update the desc so that KVM users don't find themselves scratching their head.
We would want to fix/implement this in 4.15 (?) since when using qcow2 the snaps can be kept "attached" to it, the same way they are now attached/part of the rbd image (Ceph)

ping @GabrielBrascher @wido @weizhouapache

cc @nathanejohnson (you guys implemented this, right?)

[DaanHoogland]

👎

should be 👎

[DaanHoogland]

please see my drunken comment

[andrijapanicsb]

I love you comments ❤️ don't worry 😉
say, what makes you think it's needed? this global setting is already in the DB - so my idea is to edit the DB.
The config key you've shared (AFAIK!?) would create a setting that doesn't exist, right? but since it's already there from 4.11.3, I thought to just update it?

[andrijapanicsb]

@blueorangutan package

[blueorangutan]

@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[weizhouapache]

code LGTM

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1108

[andrijapanicsb]

This was on both clean install and when 4.13.1-snapshot was upgraded to master (this PR code) -so it looks good <--- Works without the config key update

Will rebuild just for the sake of re-testing (and upgrade my envs)

[andrijapanicsb]

@blueorangutan package

[blueorangutan]

@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1110

[andrijapanicsb]

Doesn't count from my side - but this one is LGTM after manual testing

[andrijapanicsb]

for the sake of fun, I don't find the tests needed for this change.

@blueorangutan test

[blueorangutan]

@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

this PR looks good, despite travis :(

[andrijapanicsb]

@blueorangutan package

[blueorangutan]

@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[andrijapanicsb]

Looks good, except the description is incomplete 🤦‍♂

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1123

[andrijapanicsb]

@blueorangutan test

[blueorangutan]

@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1357)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41869 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3999-t1357-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	Error	186.87	test_internal_lb.py

[andrijapanicsb]

Looking good, 2 x LGTMs, manual testing regression testing OK (failed test nothing to do with the PR).

Merging.