-
Notifications
You must be signed in to change notification settings - Fork 150
Add missing array functions #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+547
−0
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b9d5f65
Add missing array/list functions and aliases (#1452)
timsaucer a7c7de4
Add unit tests for new array/list functions and aliases
timsaucer 84d7393
Improve array function APIs: optional params, better naming, restore …
timsaucer 6581b4f
Consolidate array/list function tests using pytest parametrize
timsaucer b4b8775
Move list alias tests into existing test_array_functions parametrize …
timsaucer ef48dd9
Merge test_array_any_value into parametrized test_any_value_aliases
timsaucer db91638
Add arrays_overlap and list_overlap as aliases for array_has_any
timsaucer 7ff0551
Merge branch 'main' into feat/add-missing-array-fns
timsaucer fe4e2f7
Add docstring examples for optional params in string_to_array and gen…
timsaucer dee9719
Update AGENTS file to demonstrate preferred method of documenting pyt…
timsaucer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ntjohnson1 Do you think we should add anything else here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it covers the majority of things to me. The only other piece is the stylistic preference on specifying "Returns" or not. I don't know if there is a definitive position on that.