chore: Replace stray old-style string builder in substr#22183
Open
neilconway wants to merge 1 commit into
Open
chore: Replace stray old-style string builder in substr#22183neilconway wants to merge 1 commit into
substr#22183neilconway wants to merge 1 commit into
Conversation
neilconway
changed the title
substrsubstr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
In #21519, we optimized
substrto use the new bulk-NULL string builders. That PR neglected to convert over one corner-case code path (for handlingUtf8/LargeUtf8values larger than 2GB). For consistency (and a small perf win), this PR converts that case as well.What changes are included in this PR?
StringViewBuilderfor the newStringViewArrayBuilderingeneric_string_substr_copyAre these changes tested?
Yes, covered by existing tests.
Are there any user-facing changes?
No.