feat: unify and enhance the lifecycle of an instance#1440
Open
Saramanda9988 wants to merge 16 commits intoapache:developfrom
Open
feat: unify and enhance the lifecycle of an instance#1440Saramanda9988 wants to merge 16 commits intoapache:developfrom
Saramanda9988 wants to merge 16 commits intoapache:developfrom
Conversation
…ration in informers
…tion in informers
… and fallback handling
…ging and filtering
…rvice configuration
robocanic
reviewed
Mar 29, 2026
Contributor
robocanic
left a comment
robocanic
left a comment
There was a problem hiding this comment.
Great work! I've reviewd the whole code change and the quality is really high. I left some comments and hope you can discuss them with me.
…ing and logging for ambiguous matches
…new types and improved data handling
Contributor
|
Please reslove the conflicts @Saramanda9988 |
# Conflicts: # pkg/core/discovery/subscriber/rpc_instance.go
|
Author
|
@robocanic Done, and the current style of the instance detail is as followed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
please refer to: #1399
What changed
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.
screenshot