Skip to content

Align Prometheus metrics IT assertions with metric-kind-based name mapping#1293

Merged
zrlw merged 1 commit into
apache:masterfrom
SavitarC:fix-prometheus-metric-name-assertions
Apr 23, 2026
Merged

Align Prometheus metrics IT assertions with metric-kind-based name mapping#1293
zrlw merged 1 commit into
apache:masterfrom
SavitarC:fix-prometheus-metric-name-assertions

Conversation

@SavitarC
Copy link
Copy Markdown
Contributor

Summary

This PR updates the Prometheus metrics integration tests to use metric-kind-aware assertion logic instead of hardcoded metric names.

Changes

  • add PrometheusMetricAssert to resolve compatible Prometheus metric names from Dubbo raw metric names
  • support both legacy and newer Prometheus naming conventions
  • distinguish metric kinds such as COUNTER and GAUGE when asserting exposed metrics
  • refactor ConsumerMetricsIT and ProviderMetricsIT to assert raw metric names with explicit metric kinds

@zrlw zrlw merged commit 1952d57 into apache:master Apr 23, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants