FINERACT-2600: Fix theme toggle scrolling page to top on click#57
Open
bagusrizkis wants to merge 1 commit into
Open
FINERACT-2600: Fix theme toggle scrolling page to top on click#57bagusrizkis wants to merge 1 commit into
bagusrizkis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the theme toggle anchor (
<a href="#">) with a<button type="button">, and reset background and border in CSS so the visual is identical to before.Why
JIRA: FINERACT-2600
Clicking the toggle scrolled the page to top because
href="#"triggered default anchor navigation.<button>is also semantically correct since the toggle doesn't navigate anywhere, and Space-key activation works for free.Testing
Served locally and verified the bug reproduces with the original markup, then no longer reproduces after the change. Toggled multiple times across scrolled positions, theme switches in place. Visual rendering identical to before. Tested in Safari, Chrome, and Firefox.