FINERACT-2476: Enable Group Savings Accounts as Guarantors with Guarantee Percentage Requirements#5827
Conversation
…ntee Percentage Requirements
Aman-Mittal
left a comment
Aman-Mittal
left a comment
There was a problem hiding this comment.
Please address review comments and also maintain documentation in fineract-doc
I think we can discuss this usecase more in dev list
| return this.loanTransactionHelper.getLoanId(loanApplicationJSON); | ||
| } | ||
|
|
||
| @SuppressWarnings({ "rawtypes", "unchecked" }) |
There was a problem hiding this comment.
Why we are suppressing warnings here
|
|
||
| // TODO: Rewrite to use fineract-client instead! | ||
| // Example: org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long, | ||
| // org.apache.fineract.client.models.PostLoansLoanIdRequest) |
There was a problem hiding this comment.
I think You should not write anymore test cases here.
| || guarantorFundingDetails.getStatus().isCompleted()) { | ||
| if (guarantor.isSelfGuarantee()) { | ||
| SavingsAccount savingsAccount = guarantorFundingDetails.getLinkedSavingsAccount(); | ||
| if (savingsAccount.isGroupAccount()) { |
There was a problem hiding this comment.
Just trying to understand the intended business behavior here:
for client loans, if the borrower belongs to the same group whose savings account is being used as guarantee, should that still be classified as an external guarantee?
Right now it looks like only loan.getGroupId() is considered for self-guarantee classification.
| if (savingsAccount.isGroupAccount()) { | ||
| // Group loan with the same group's savings account → self-guarantee | ||
| // Client loan or different group's savings → external guarantee | ||
| if (loan.getGroupId() != null && loan.getGroupId().equals(savingsAccount.getGroupId())) { |
There was a problem hiding this comment.
Right now code seems to be handling
| Case | Classification |
|---|---|
| Group loan + same group savings | self |
| Client loan + same group savings | external |
Please confirm me about this case I am also new to this logic
| Case | Classification |
|---|---|
| Client belongs to same guarantor group | maybe self / partial self |
2 participants
Group savings accounts should be usable as guarantors regardless of guarantee percentage requirements, as long as:
Checklist