Repository navigation
[server] Recover KV tables after complete local disk loss - #4567
Open
swuferhong wants to merge 1 commit into
Open
swuferhong wants to merge 1 commit into
swuferhong wants to merge 1 commit into
Conversation
Restore empty replica log offsets and writer state from the durable snapshot and remote WAL before rebuilding KV state. Reject missing recovery ranges, clean up failed KV initialization, and resume tiering across a WAL gap covered by the recovered snapshot. Add coverage for all-replica disk loss, acknowledged tail loss, resumed writes and replication, writer deduplication, expired or truncated remote logs, and interrupted recovery. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-6 AI-Contributed/Feature: 309/309 AI-Contributed/UT: 433/433
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore empty replica log offsets and writer state from the durable snapshot and remote WAL before rebuilding KV state. Reject missing recovery ranges, clean up failed KV initialization, and resume tiering across a WAL gap covered by the recovered snapshot.
Purpose
Linked issue: close #4566
After complete local disk loss, KV recovery can fail because an empty local log starts at offset 0 while the retained snapshot references a higher offset. This change restores the log boundary before replaying KV state.
Non-empty local logs are preserved. Recovery may lose acknowledged writes beyond the recoverable boundary; it does not guarantee that every pre-failure changelog offset remains readable.
Brief change log
Tests
API and Format
Documentation