Skip to content

Enhance URI scheme validation for Windows paths #3161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlgoDeveloper400 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhance URI scheme validation for Windows paths #3161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pyiceberg/io/pyarrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,8 @@ def parse_location(location: str, properties: Properties = EMPTY_DICT) -> tuple[
"""
uri = urlparse(location)

if not uri.scheme:
if not uri.scheme or (len(uri.scheme) == 1 and uri.scheme.isalpha()):
# len == 1 and alpha catches Windows drive letters like C:\ D:\
default_scheme = properties.get("DEFAULT_SCHEME", "file")
default_netloc = properties.get("DEFAULT_NETLOC", "")
return default_scheme, default_netloc, os.path.abspath(location)
Expand All @@ -406,6 +407,7 @@ def parse_location(location: str, properties: Properties = EMPTY_DICT) -> tuple[
else:
return uri.scheme, uri.netloc, f"{uri.netloc}{uri.path}"


def _initialize_fs(self, scheme: str, netloc: str | None = None) -> FileSystem:
"""Initialize FileSystem for different scheme."""
if scheme in {"oss"}:
Expand Down
Loading