#15510 Parquet: Support row group skipping for shredded variant columns#16133
Draft
steveloughran wants to merge 4 commits into
Draft
#15510 Parquet: Support row group skipping for shredded variant columns#16133steveloughran wants to merge 4 commits into
steveloughran wants to merge 4 commits into
Conversation
Contributor
Author
|
This doesn't get called from spark until multiple PRs are merged: |
steveloughran
force-pushed
the
pr/variant-rowgroups
branch
2 times, most recently
from
a10c7e5 to
8474d0d
Compare
steveloughran
force-pushed
the
pr/variant-rowgroups
branch
2 times, most recently
from
1e0f654 to
f4c129d
Compare
Contributor
Author
|
big milestone reached today w/ spark and parquet all lined up. Got a stack trace saying can't deser variant as the bytebuffer is in the wrong order. This could potentially mean that predicate pushdown is working down but some bytebuffer is OOO. Or it is something unrelated. New stack though |
steveloughran
force-pushed
the
pr/variant-rowgroups
branch
2 times, most recently
from
1106d2b to
ab5561c
Compare
…kipping copilot's solution to why pushdown wasn't working, independent of qlong's apache#15385 I plan to take qlong's and pull what is extra from this one.
ParquetMetricsRowGroupFilter.compareVariant() implements comparisons for variants, including NaN, null, uuid, set membership. * New ParquetVariantUtil splitter regexp can't cope with columns called ]. That's OK as normalisation forbids that and empty paths * Copilot wrote the tests so it's over-verbose, but thorough. * including NaN behaviour and string truncation on max values. * lazy build of variant mapping info, cached for entire file. There's no concurrency handling here in the build up of that lazy structure, once happy with the design it'll need to be locked down better. TestSparkVariantFilterPushDown to test variant pushdown through spark This needs a modified spark, currently. A package private counter is exported from ParquetMetricsRowGroupFilter to assist in testing as it can assess #of lookups during planning and execution.
Allows for assertions in tests and in benchmarks that rowgroup skipping is taking place. Needed as there's not much tangible speedup, yet Change-Id: I8c03eb33d2d3d8a2139c347e6a72a7284e627f62
Filtering is working well enough to not need logging on normal execution. Change-Id: Ief88bbe7e1df28a93b1fd988f6d9f224fbb846e0
steveloughran
force-pushed
the
pr/variant-rowgroups
branch
from
ab5561c to
6ad21e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParquetMetricsRowGroupFilter.compareVariant() implements comparisons for variants, including NaN, null.
Fixes #15510
Testing notes
Full branch with this, Qlong's api changes and the benchmark is https://github.com/steveloughran/iceberg/tree/pr/variant-rowgroups-benchmark
Does need a matching spark version.